BookmarkSubscribeRSS Feed
🔒 This topic is solved and locked. Need further help from the community? Please sign in and ask a new question.
kanivan51
Obsidian | Level 7

Hello!

 

What is wrong with that script?

 

%LET MIN=1;
%LET MAX=1000000;

;DATA IDS(KEEP=ID);
RETAIN I;
ATTRIB ID FORMAT=12.;
I=1;
MAX=&MAX.;
DO (WHILE ID<MAX);
ID=&MIN.*I;
OUTPUT;
I+1;
END;
RUN;

1 ACCEPTED SOLUTION

Accepted Solutions
Kurt_Bremser
Super User

Maxim 2: Read the log.

 

You get this:

1         MAX=&MAX.;
32         DO (WHILE ID<MAX);
                     __
                     22
ERROR: Undeclared array referenced: DO.
32         DO (WHILE ID<MAX);
                            _
                            22
ERROR 22-322: Syntax error, expecting one of the following: !, !!, &, (, *, **, +, ',', -, /, <, <=, <>, =, >, ><, >=, AND, EQ, GE, 
              GT, IN, LE, LT, MAX, MIN, NE, NG, NL, NOTIN, OR, [, ^=, {, |, ||, ~=.  

ERROR 22-322: Syntax error, expecting one of the following: +, =.  

32         DO (WHILE ID<MAX);
                            _
                            76
ERROR 76-322: Syntax error, statement will be ignored.

which points to a problem with the way you wrote the do statement.

Maxim 1: Read the documentation.

The documentation for the do while statement reads:

Syntax

DO WHILE (expression);

 

which means that the opening parenthesis must come after the "while".

 

Now look at this:

%let min=1;
%let max=1000000;

data ids(keep=id);
attrib id format=12.;
I = 1;
max = &max.;
do while (id < max);
  id = &min. * i;
  output;
  i + 1;
end;
run;

and tell us which code is easier to read and understand?

Follow Maxim 12, and avoid coding in all-uppercase. The 1950's are long past.

 

BTW I removed the unnecessary retain statement. Read the documentation what it does and when it should be used.

View solution in original post

6 REPLIES 6
andreas_lds
Jade | Level 19
  1. You code all upcase.
  2. You didn't use the {i} or running-man-icon to post the code.
  3. I don't have a crystal ball showing the log output and/or what you expected.
kanivan51
Obsidian | Level 7
%LET MIN=1;
%LET MAX=1000000;

;DATA IDS(KEEP=ID);
RETAIN I;
ATTRIB ID FORMAT=12.;
I=1;
MAX=&MAX.;
DO (WHILE ID<MAX);
ID=&MIN.*I;
OUTPUT;
I+1;
END;
RUN;

err.JPG

ballardw
Super User

Post LOG information into a code box as well. Then we can cut an paste to show corrections or explanations.

Kurt_Bremser
Super User

Maxim 2: Read the log.

 

You get this:

1         MAX=&MAX.;
32         DO (WHILE ID<MAX);
                     __
                     22
ERROR: Undeclared array referenced: DO.
32         DO (WHILE ID<MAX);
                            _
                            22
ERROR 22-322: Syntax error, expecting one of the following: !, !!, &, (, *, **, +, ',', -, /, <, <=, <>, =, >, ><, >=, AND, EQ, GE, 
              GT, IN, LE, LT, MAX, MIN, NE, NG, NL, NOTIN, OR, [, ^=, {, |, ||, ~=.  

ERROR 22-322: Syntax error, expecting one of the following: +, =.  

32         DO (WHILE ID<MAX);
                            _
                            76
ERROR 76-322: Syntax error, statement will be ignored.

which points to a problem with the way you wrote the do statement.

Maxim 1: Read the documentation.

The documentation for the do while statement reads:

Syntax

DO WHILE (expression);

 

which means that the opening parenthesis must come after the "while".

 

Now look at this:

%let min=1;
%let max=1000000;

data ids(keep=id);
attrib id format=12.;
I = 1;
max = &max.;
do while (id < max);
  id = &min. * i;
  output;
  i + 1;
end;
run;

and tell us which code is easier to read and understand?

Follow Maxim 12, and avoid coding in all-uppercase. The 1950's are long past.

 

BTW I removed the unnecessary retain statement. Read the documentation what it does and when it should be used.

RW9
Diamond | Level 26 RW9
Diamond | Level 26

Not sure what all the while part is for in the first place, it is a simple loop with a by statement:

data ids2;
  attrib id format=12.;
  do id=&min. to &max. by &min.;
    output;
  end;
run; 
kanivan51
Obsidian | Level 7
Thanks, RW9! Cool solution! I didn't know about BY statement in loop.

sas-innovate-2024.png

Join us for SAS Innovate April 16-19 at the Aria in Las Vegas. Bring the team and save big with our group pricing for a limited time only.

Pre-conference courses and tutorials are filling up fast and are always a sellout. Register today to reserve your seat.

 

Register now!

SAS Enterprise Guide vs. SAS Studio

What’s the difference between SAS Enterprise Guide and SAS Studio? How are they similar? Just ask SAS’ Danny Modlin.

Find more tutorials on the SAS Users YouTube channel.

Click image to register for webinarClick image to register for webinar

Classroom Training Available!

Select SAS Training centers are offering in-person courses. View upcoming courses for:

View all other training opportunities.

Discussion stats
  • 6 replies
  • 9193 views
  • 4 likes
  • 5 in conversation