Hello!
What is wrong with that script?
%LET MIN=1;
%LET MAX=1000000;
;DATA IDS(KEEP=ID);
RETAIN I;
ATTRIB ID FORMAT=12.;
I=1;
MAX=&MAX.;
DO (WHILE ID<MAX);
ID=&MIN.*I;
OUTPUT;
I+1;
END;
RUN;
Maxim 2: Read the log.
You get this:
1 MAX=&MAX.; 32 DO (WHILE ID<MAX); __ 22 ERROR: Undeclared array referenced: DO. 32 DO (WHILE ID<MAX); _ 22 ERROR 22-322: Syntax error, expecting one of the following: !, !!, &, (, *, **, +, ',', -, /, <, <=, <>, =, >, ><, >=, AND, EQ, GE, GT, IN, LE, LT, MAX, MIN, NE, NG, NL, NOTIN, OR, [, ^=, {, |, ||, ~=. ERROR 22-322: Syntax error, expecting one of the following: +, =. 32 DO (WHILE ID<MAX); _ 76 ERROR 76-322: Syntax error, statement will be ignored.
which points to a problem with the way you wrote the do statement.
Maxim 1: Read the documentation.
The documentation for the do while statement reads:
which means that the opening parenthesis must come after the "while".
Now look at this:
%let min=1;
%let max=1000000;
data ids(keep=id);
attrib id format=12.;
I = 1;
max = &max.;
do while (id < max);
id = &min. * i;
output;
i + 1;
end;
run;
and tell us which code is easier to read and understand?
Follow Maxim 12, and avoid coding in all-uppercase. The 1950's are long past.
BTW I removed the unnecessary retain statement. Read the documentation what it does and when it should be used.
%LET MIN=1;
%LET MAX=1000000;
;DATA IDS(KEEP=ID);
RETAIN I;
ATTRIB ID FORMAT=12.;
I=1;
MAX=&MAX.;
DO (WHILE ID<MAX);
ID=&MIN.*I;
OUTPUT;
I+1;
END;
RUN;
Post LOG information into a code box as well. Then we can cut an paste to show corrections or explanations.
Maxim 2: Read the log.
You get this:
1 MAX=&MAX.; 32 DO (WHILE ID<MAX); __ 22 ERROR: Undeclared array referenced: DO. 32 DO (WHILE ID<MAX); _ 22 ERROR 22-322: Syntax error, expecting one of the following: !, !!, &, (, *, **, +, ',', -, /, <, <=, <>, =, >, ><, >=, AND, EQ, GE, GT, IN, LE, LT, MAX, MIN, NE, NG, NL, NOTIN, OR, [, ^=, {, |, ||, ~=. ERROR 22-322: Syntax error, expecting one of the following: +, =. 32 DO (WHILE ID<MAX); _ 76 ERROR 76-322: Syntax error, statement will be ignored.
which points to a problem with the way you wrote the do statement.
Maxim 1: Read the documentation.
The documentation for the do while statement reads:
which means that the opening parenthesis must come after the "while".
Now look at this:
%let min=1;
%let max=1000000;
data ids(keep=id);
attrib id format=12.;
I = 1;
max = &max.;
do while (id < max);
id = &min. * i;
output;
i + 1;
end;
run;
and tell us which code is easier to read and understand?
Follow Maxim 12, and avoid coding in all-uppercase. The 1950's are long past.
BTW I removed the unnecessary retain statement. Read the documentation what it does and when it should be used.
Not sure what all the while part is for in the first place, it is a simple loop with a by statement:
data ids2; attrib id format=12.; do id=&min. to &max. by &min.; output; end; run;
Don't miss out on SAS Innovate - Register now for the FREE Livestream!
Can't make it to Vegas? No problem! Watch our general sessions LIVE or on-demand starting April 17th. Hear from SAS execs, best-selling author Adam Grant, Hot Ones host Sean Evans, top tech journalist Kara Swisher, AI expert Cassie Kozyrkov, and the mind-blowing dance crew iLuminate! Plus, get access to over 20 breakout sessions.
What’s the difference between SAS Enterprise Guide and SAS Studio? How are they similar? Just ask SAS’ Danny Modlin.
Find more tutorials on the SAS Users YouTube channel.