Hi: Read about the colon format modifer for the INPUT statement. If you are going to specify an INFORMAT on your INPUT statement, you need the colon format modifier, such as: input ID $ Date : mmddyy.; Cynthia ... View more

PROC SQL; CREATE TABLE work.counts AS SELECT Report_Month, CASE WHEN P = 'ACC' THEN 'A' WHEN P = 'DCL' AND S = 'ACC' THEN 'B' WHEN P = 'DLC' AND S = 'DLC' AND SS = 'ACC' THEN 'C' WHEN SS = 'DLC' THEN 'E' END AS Risk, COUNT(DISTINCT SSN) AS COUNT FROM work.Master GROUP BY Report_Month, calculated Risk; QUIT; I removed COUNT from the group by.  I added the keyword calculated before the variable RISK.  SAS needs an identifying keyword when you use a derived column/field/variable when it is built and used within the same query.   ... View more

What you have:   %LOCAL i j;   %DO &i.=0 %TO 70;   %LET &j = %EVAL(&i.+1);   What it should be:   %LOCAL i j;   %DO i=0 %TO 70;   %LET j = %EVAL(&i.+1);   The correct syntax for referring to a macro variable has nothing at all to do with whether the variable is local or global.  %DO and %LET have the same syntax rules that apply to both local and global variables.   Where the %LOCAL statement belongs:  within every macro definition that uses &i or &j.  (There are a few, complex exceptions that you are not likely to encounter.) ... View more

Quick summary: I break my programs into logical bits. 1. Data import 2. Data cleaning 3a. Labels, formats 3b. Macros needed 3c. Style templates needed 4. Analysis 5. Reporting I label programs P001 - Program name is long name.sas P002 - blah blah This means programs sort in order. I also set up several folders: rawData cleanData SAS PRograms SAS Data sets SAS output Deliverables References And others as needed. Other best practices: 1. Description of program at top of program 2. Comments - make them context oriented, why are you doing this? Assume the user can read SAS code, but needs to know why you're doing something. Eg Recoding variables to 0/1 from Y/N to allow for quick summarization in proc means. 3. Look for multiple similar steps, 3 data steps back to back can likely be combined. That's just a quick starter. If you're looking for more advice, please search on lexjansen.com for best practices guides. ... View more