@Zizie wrote: %macro dev(yymmdd); proc import datafile = "I:\CRMD\Vintage analysis\Core Banking Data\text data\DEVIATION\Deviation_Tracking_as_at_&yymmdd1..txt" out = DEV.Deviation_Tracking_&yymmdd1. dbms = dlm replace; delimiter = '|'; run; %mend; %DEV(yymmdd1); It looks very suspicious that you define the macro to use a parameter YYMMDD but use the macro variable YYMMDD1. So it is quite likely that what you think you pass to the macro is not quite what is used. ... View more

With a numeric value, you have to take care of the conversion from numeric to character. substr() is a character function. If you always have 4 digits, you could keep it numeric: data _null_; LOAN_APPLCTN_BNM_CODE = 1232; new1 = int(LOAN_APPLCTN_BNM_CODE/100); put new1=; run; Log: 27 data _null_; 28 LOAN_APPLCTN_BNM_CODE = 1232; 29 new1 = int(LOAN_APPLCTN_BNM_CODE/100); 30 put new1=; 31 run; new1=12 "Clean" programming (see Maxim 25) mandates the avoidance of implicit type conversions (and the corresponding NOTEs in the log): data _null_; LOAN_APPLCTN_BNM_CODE = 1232; new1 = substr(left(put(LOAN_APPLCTN_BNM_CODE,4.)),1,2); put new1=; run; Log: 27 data _null_; 28 LOAN_APPLCTN_BNM_CODE = 1232; 29 new1 = substr(left(put(LOAN_APPLCTN_BNM_CODE,4.)),1,2); 30 put new1=; 31 run; new1=12 ... View more