parameter in macros

[SAS_inquisitive]

Hello,

Is it legal to use same parameter in both outer and inner macro here?

%macro inner (ds = );
	proc print data = &ds.;
	run;
%mend;

%macro outer (ds =);
	%inner(ds = &ds.);
%mend outer;
%outer (ds = sashelp.class)

[Astounding]

It is legal.

It should be avoided unless absolutely necessary.  It becomes difficult to tell what &DS refers to, since the values in the inner and outer macros do not have to match.

[Reeza]

It's legal, but not a good idea.

[SAS_inquisitive]

@Astounding  @Reeza . Thanks. In my case the macro variable value is same in both outer and inner. I want to add the extra parameter in outer macro for further processing.

[Astounding · Accepted solution]

You'll be fine.  Do you understand the results that this variation would create?

%macro inner (ds = );
	proc print data = &ds.;
	run;
        %let ds = temp;
        %put Inner DS is &DS;
%mend;

%macro outer (ds =);
	%inner(ds = &ds.);
        %put outer DS is &DS;
%mend outer;
%outer (ds = sashelp.class)

[SAS_inquisitive]

@Astounding, You are overriding the name of macro variable &ds in inner macro.

[Astounding]

Yes, while the value in the outer macro remains unchanged.

You'll be fine with what you are planning.

[Tom]

Yes.

Not sure why some are saying it is not desirable.  Use the same name if it makes the code easier to understand, or use different names if that makes more sense.