Problem with concatenation

[Sathya3]

%let source = other_rfb; /* Example value for the macro variable */

data glow;
input id $ source $ class $ country $;
datalines;
11e other mid au
23 other_rfb large eu
123ab other small other in
;
run;

data glow2;
set glow;
length id $200;
if "&source" in ("other", "other_rfb") then do;
id = class || "_under_250k" || country;
end;
else do;
id = class || "_under_250k";
end;

run;

Concatenation is not happening for id coulmn .id just has class values in glow2 dataset. Can you please help with correct code. Tried with cats as well

[PaigeMiller · Accepted solution]

Please read the log, it tells you what the problem is.

45    data glow2;
46    set glow;
47    length id $200;
WARNING: Length of character variable id has already been set.
         Use the LENGTH statement as the very first statement in the DATA STEP to declare the length of a character variable.
48    if "&source" in ("other", "other_rfb") then do;
49    id = class || "_under_250k" || country;
50    end;
51    else do;
52    id = class || "_under_250k";
53    end;
54
55    run;

Your LENGTH statement didn't do anything where it is located. The LOG even tells you how to fix it.