BookmarkSubscribeRSS Feed
🔒 This topic is solved and locked. Need further help from the community? Please sign in and ask a new question.
hhchenfx
Barite | Level 11

Hi Everyone,

For each id, I want to calculate moving average using values not equal to 0.

For the data below with moving average of 3 lag 1, the average for record 4 should take (3+9)/2; record 5 will have 9/1.

The proc expand with WHERE v2>0 is not working that way.

Can you please help?

Thanks,

HHC

data have;
input date id v2;
datalines;
1 1 3
2 1 0
3 1 9
4 1 0
5 1 5
1 2 0
2 2 0
3 2 9
4 2 0
5 2 5
;run;

*NOT right;
proc expand data=have out=want;
where v2>0;
convert v2 = avg/transformout=(MOVave  3 lag 1);
run;
1 ACCEPTED SOLUTION

Accepted Solutions
mkeintz
PROC Star

You want the average of the previous three observations, excluding thoses with V2=0.  How about a DATA step:

 

data have;
input date id v2;
datalines;
1 1 3
2 1 0
3 1 9
4 1 0
5 1 5
1 2 0
2 2 0
3 2 9
4 2 0
5 2 5
;run;

data want;
  array prev_three {3} _temporary_;
  set have;
  by id;
  if first.id then call missing(of prev_three{*});
  avg=mean(of prev_three{*});
  prev_three{mod(_n_,3)+1}=ifn(v2>0,v2,.);
run;

The important thing here is that AVG is calculated prior to replacing the 3rd previous value of V2 in the PREV_THREE array with the current value.

--------------------------
The hash OUTPUT method will overwrite a SAS data set, but not append. That can be costly. Consider voting for Add a HASH object method which would append a hash object to an existing SAS data set

Would enabling PROC SORT to simultaneously output multiple datasets be useful? Then vote for
Allow PROC SORT to output multiple datasets

--------------------------

View solution in original post

6 REPLIES 6
mkeintz
PROC Star

Shouldn't it be

convert v2 = avg/transformout=(MOVave 1 lag 3);
--------------------------
The hash OUTPUT method will overwrite a SAS data set, but not append. That can be costly. Consider voting for Add a HASH object method which would append a hash object to an existing SAS data set

Would enabling PROC SORT to simultaneously output multiple datasets be useful? Then vote for
Allow PROC SORT to output multiple datasets

--------------------------
hhchenfx
Barite | Level 11

convert v2 = avg/transformout=(MOVave 1 lag 3);

will take average of 3 prior cell regardless of cell value, so it will not work.

Thanks.

HHC

hhchenfx
Barite | Level 11

Hi,

I do the vertical/Excel kind of way.

It works.

If you have a shorter method, please let me know.

Thanks,

HHC

 

data have;
input date id value;
datalines;
1 1 3
2 1 0
3 1 9
4 1 0
5 1 5
1 2 1
2 2 0
3 2 9
4 2 0
5 2 5
;run;

proc sort data=have; by id descending date;run;

data want; set have;
drop id1 date1 v1;
SUM=0;
Count=0;
do i=_N_ +1 to _N_+3;

	set have (rename = (date=date1 id=id1 value=v1)) point=i;
		if id1=id and v1^=0 then do;
			sum=sum+v1;
			count=count+1;
		end;
		average=sum/count;
end;
output;
run;
ballardw
Super User

Easiest is very likely 1) add a new variable that is missing when the variable you want to average is missing

2) expand that new variable

3) (may want to remove the added variable)

mkeintz
PROC Star

You want the average of the previous three observations, excluding thoses with V2=0.  How about a DATA step:

 

data have;
input date id v2;
datalines;
1 1 3
2 1 0
3 1 9
4 1 0
5 1 5
1 2 0
2 2 0
3 2 9
4 2 0
5 2 5
;run;

data want;
  array prev_three {3} _temporary_;
  set have;
  by id;
  if first.id then call missing(of prev_three{*});
  avg=mean(of prev_three{*});
  prev_three{mod(_n_,3)+1}=ifn(v2>0,v2,.);
run;

The important thing here is that AVG is calculated prior to replacing the 3rd previous value of V2 in the PREV_THREE array with the current value.

--------------------------
The hash OUTPUT method will overwrite a SAS data set, but not append. That can be costly. Consider voting for Add a HASH object method which would append a hash object to an existing SAS data set

Would enabling PROC SORT to simultaneously output multiple datasets be useful? Then vote for
Allow PROC SORT to output multiple datasets

--------------------------
hhchenfx
Barite | Level 11

Your code is amazing.

It work much much faster than my code!!!

Thank you,

HHC

sas-innovate-2024.png

Available on demand!

Missed SAS Innovate Las Vegas? Watch all the action for free! View the keynotes, general sessions and 22 breakouts on demand.

 

Register now!

How to Concatenate Values

Learn how use the CAT functions in SAS to join values from multiple variables into a single value.

Find more tutorials on the SAS Users YouTube channel.

Click image to register for webinarClick image to register for webinar

Classroom Training Available!

Select SAS Training centers are offering in-person courses. View upcoming courses for:

View all other training opportunities.

Discussion stats
  • 6 replies
  • 935 views
  • 1 like
  • 3 in conversation