datastep inside a macro type question

[deleted_user]

what is wrong with my following code? your help is really appreciated
%let mcy=9;
%macro read;
filename in " path\fictional_data.txt";
data read;
infile in end=eof lrecl=10;
input @1 i&mcy.IDO $CHAR2.
@3 i&mcy.IPSS $CHAR5.
@8 i&mcy.IPHP $CHAR3.
;
%if (i&mcy.IDO ne 'AL' and i&mcy.IDO ne 'AK' ) and (i&mcy.IPSS ne ' ')
and (i&mcy.IPHP ne " " and i&mcy.IPHP ne "000" ) %then i&mcy.IDO="FR";
%else
%do ;
i&mcy.IDO="XX";
%end;
run;
%mend read;
%read

this is the log error i am getting

NOTE: Line generated by the invoked macro "READ".
5 run;
---
22
MPRINT(READ): i9IDO="FR" run
MLOGIC(READ): Ending execution.
ERROR 22-322: Syntax error, expecting one of the following: !,
!!, &, *, **, +, -, /, <, <=, <>, =, >, ><, >=,
AND, EQ, GE, GT, IN, LE, LT, MAX, MIN, NE, NG,
NL, NOTIN, OR, ^=, |, ||, ~=.

************any help is appreciated!!!!!!!!!!!! Message was edited by: statmn

[deleted_user]

Try removing % sign in if-else-then and do-end loop statments.

~ Sukanya E

[deleted_user]

> Try removing % sign in if-else-then and do-end loop
> statments.
>
> ~ Sukanya E

It worked perfectly and Thanks infinitely
I guess the issue i had initially was execution time versus interpretation time
wasn't ?
What do you think i should know about in order to avoid this kind of problems ?
thanks in advance

[sbb]

Solid understanding of differences between SAS macro compilation and SAS DATA/PROC step execution. Also, my suggestion is to always code a RUN; to force SAS code interpretation.

A few handy SAS diagnostics commands to use (frequently):

OPTIONS SOURCE SOURCE2;

OPTIONS MACROGEN SYMBOLGEN MLOGIC;


And for DATA step processing, the judicious use of PUTLOG (new with SAS 9) to echo messages during execution, for example:

PUTLOG '>DIAG01' / _ALL_;


Scott Barry
SBBWorks, Inc.