Using the 'or' statement

[jcis7]

Hello,

I am trying to write code that will catch any fields that aren't within 3 specified values for buildingtype:  PUBLIC, PRIVATE, AND UNKNOWN.

I tried this:

data clean;
set have;
 btype_error=0;
  if btype ne 'PUBLIC'  or btype ne 'PRIVATE' or btype ne 'UNKNOWN' then btype_error=1;
run;

But, I'm getting btype_error=1 for all of the observations.

What am I doing wrong? Thanks.

[Astounding · Accepted solution]

OR is incorrect.  For example, if the value is PUBLIC, then the comparison ne 'UNKNOWN' must be true.  Just change OR to AND.

Alternatively, you may find this easier to read (provided that you want to compare BTYPE each time, and not SCHTYPE):

if btype not in ('PUBLIC', 'PRIVATE', 'UNKNOWN') then btype_error=1;

[jcis7]

Thank you very much!

[jcis7]

Yes, I want to compare btype every time.  schtype was a typo. I edited it and replaced it with btype.  Thanks!