Stucked with connection to SQLSVR

[Alex91]

Hi, im new one to SAS and stucked with such problem

I'm trying to run next code and getting error below. 

proc sql;
CONNECT TO SQLSVR as con1
(Datasrc=CIDWH authdomain=MSSQLCIDB1);
CREATE TABLE &m_abt..&pre.SEASON as
select *
from connection to con1(
      select 
      case
          when month(RIRA_stg.TRANSDATE) in (12,1,2,) then 'Winter'
          when month(RIRA_stg.TRANSDATE) in (3,4,5) then 'Spring'
          when month(RIRA_stg.TRANSDATE) in (6,7,8) then 'Summer'
          when month(RIRA_stg.TRANSDATE) in (9,10,11) then 'Autumn'
      end 
      as SEASON
      FROM &m_dds..RAW_RETAIL_INTERNET_ABT_stg RIRA_stg      
      );
DISCONNECT FROM con1;
quit;

MPRINT(CREATE_TARGET_V2): CREATE TABLE ABT.ABT_31JAN18_SEASON as select * from connection to con1( select case when
month(RIRA_stg.TRANSDATE) in (12,1,2,) then 'Winter' when month(RIRA_stg.TRANSDATE) in (3,4,5) then 'Spring' when
month(RIRA_stg.TRANSDATE) in (6,7,8) then 'Summer' when month(RIRA_stg.TRANSDATE) in (9,10,11) then 'Autumn' end as
RIRA_stg.TRANSDATE FROM abt.RAW_RETAIL_INTERNET_ABT_stg RIRA_stg );
ERROR: CLI describe error: [SAS][ODBC SQL Server Wire Protocol driver][Microsoft SQL Server]Incorrect syntax near ')'. : [SAS][ODBC
SQL Server Wire Protocol driver][Microsoft SQL Server]The batch could not be analyzed because of compile errors.

What i supposed to do to fix this problem?

[VDD]

did you setup an ODBC connection?

[Alex91]

Nope. I have a similar node with code like

and it works great

proc sql;
	CONNECT TO SQLSVR as con1
		(Datasrc=CIDWH authdomain=MSSQLCIDB1);
	CREATE TABLE &m_abt..&pre.SSN_SUM AS
		select *
			from connection to con1(
				
					select 
					SUM(RIRA_stg.SUM_qty) AS SSN_SUM
					FROM &m_dds..RAW_RETAIL_INTERNET_ABT_stg RIRA_stg
					WHERE RIRA_stg.TRANSDATE BETWEEN DATEADD(YY, -1, %Cnv_date_MSsql(&mv_abt_dt_.+&delay_p.+1)) 
						and DATEADD(YY, -1, %Cnv_date_MSsql(&mv_abt_dt_.+&delay_p.+&purchase_p.))
								AND RIRA_stg.CATEGORY = %quote(%'&category_n%')
									AND RIRA_stg.SUBCATEGORY = %quote(%'&subcategory_n%')

								
				
								);
	DISCONNECT FROM con1;
quit;

the whole code is 

%macro create_target_v2(delay_p, purchase_p);

%macro d;
%mend d;

%if &mv_score = 0
%then %do;

proc sql;
CONNECT TO SQLSVR as con1
(Datasrc=CIDWH authdomain=MSSQLCIDB1);
CREATE TABLE &m_abt..&pre.SEASON as
select *
from connection to con1(
      select 
      case
          when month(RIRA_stg.TRANSDATE) in (12,1,2,) then 'Winter'
          when month(RIRA_stg.TRANSDATE) in (3,4,5) then 'Spring'
          when month(RIRA_stg.TRANSDATE) in (6,7,8) then 'Summer'
          when month(RIRA_stg.TRANSDATE) in (9,10,11) then 'Autumn'
      end 
      as SEASON
      FROM &m_dds..RAW_RETAIL_INTERNET_ABT_stg RIRA_stg      
      );
DISCONNECT FROM con1;
quit;
      




proc datasets lib=&m_abt.;
modify &pre.SEASON;
/*label
SEASON=""*/
;
run;

%end;

%mend create_target_v2;

%create_target_v2(&delay_period., &purchase_period.);

[RW9]

Well, one thing which jumps out at me, syntax for case statement is:

case <statement> when <condition> then <result> else <result> end

or

case when <condition> then <result> else <result> end

I.e. there should always be an else part of a case statement.

Other than that, without knowing the macro variable information I can't see anything syntactically wrong.

[Alex91]

Thanks, you are totally right about case statement but anyway it didn't help for me still getting the same error =(

Perhaps that's macro variable issue.

[RW9]

In which case turn on macro print options:

options mlogic mprint symbolgen source source2;

Before your SQL, and look at the log and see what code is being generated.  Ensure that it is correct and valid code.

[VDD · Accepted solution]

another error is you have an incorrect comma in this statement

when month(RIRA_stg.TRANSDATE) in (12,1,2,) then 'Winter'

remove the , after the last 2 also

Do you know SAS or are you changing someone else's code. You could always ask the original owner of the code for help.

[Alex91]

I'm totally confused about this comma! Seems like i'm blind.

Yes, that's my own code.

thanks a lot.

[VDD]

@Alex91 has when month(RIRA_stg.TRANSDATE) in (12,1,2,) then 'Winter'

change it to    when month(RIRA_stg.TRANSDATE) in (12,1,2) then 'Winter'

do you see you had 2,) but it should be 2)