Change Varaible Names with Macro

[A_Halps]

I am trying to change the names of certain variables with a macro because I have many different variables.

So, I need q7_16 = Mild, q7_17 = Moderate, q7_18 = Severe, q7_19 = As_bad, q7_2094 = No_wheeze, and q7_2095 = Wheeze_whistle.

This is what I have tried, but I can't seem to change all of the variables. It will only change the last one.

%macro question (ans_num, answer, label);
proc sql; 
	create table severity_lrd_v3b_names as 
		select *, 
			q7_&ans_num as &answer label &label
			from severity_lrd_v3b;
quit;
%mend; 
%question (16, Mild, 'Mild');
%question (17, Moderate, 'Moderate');
%question (18, Severe, 'Severe');
%question (19, As_bad, 'As_bad');
%question (2094,No_wheeze, 'No_wheeze');
%question (19, Wheeze_whistle, 'Wheeze_whistle');  

[Reeza]

Do you have a data set that has the old and new names? If you do, or can create that one, I have a macro you can use here, it's super efficient because it uses PROC DATASETS. Your code above doesn't work, because each time you're starting from severity_lrd_v3b which does not have the previous runs changes so you'll only see the results of the last macro call.

[A_Halps]

I only have a dataset with the q7_16 variables. Not one with the actual words

[Reeza]

Can you make one? Seems easier than macro calls but ultimately your choice.

If you want to fix your macro above you just need to change the data set name as I mentioned previously so it's re-using the same data set each time so it adds to it instead of using the original data set.

[Tom · Accepted solution]

Only the last call has any effect because you keep re-reading the original dataset.

The easiest change might be to make the macro just generate part of the SQL code.

%macro question (ans_num, answer, label);
q7_&ans_num as &answer label &label

%mend; 
proc sql; 
  create table severity_lrd_v3b_names as 
    select *
    ,%question (16, Mild, 'Mild')
    ,%question (17, Moderate, 'Moderate')
    ,%question (18, Severe, 'Severe')
    ,%question (19, As_bad, 'As_bad')
    ,%question (2094,No_wheeze, 'No_wheeze')
    ,%question (19, Wheeze_whistle, 'Wheeze_whistle')
    from severity_lrd_v3b
  ;
quit;

But of course at that point you should recognize that you don't need the macro at all as it is just as easy to type the actual code as the macro calls.