SAS V9.4 on Windows 10. I will be performing some testing of new storage behind a Brocade switch. The testing will require enabling and disabling specific ports and changing the speed for some ports. I have written a macro to build files for each test. They are being written to my user/me/ folder. I want to have the main program use a folder in the filename statement and then have each file I am building be a file within that Windows folder. I have a second issue. I have a series of nested loops. The outer most loop is   'do type = 'A','N';  the inner most within each creates a file that has way too many lines in it. Most will have 8-10 records, the inner most within the TYPE loop however is getting hundreds. Perhaps  it is getting every record created and placed into the other files.   So main question is: how do I set the file names to be in the folder  the main program uses as the location of the filename? 2nd question is can you see why the inner most loop is getting an excessive number of records? ... View more

After 35+ years of using data step programming I am trying to learn Proc SQL. I have something I've written and works but believe it can be streamlined.   The code below reads in a CSV file containing a list of tape volumes in a virtual tape library and the status of the volumes (ie: 'Cataloged' or 'Scratch'). The end goal is to merge that with a text file coming from the mainframe listing dataset names and tape volume and building control cards to delete the z/OS catalog entry for any tape volume in that mainframe listing that the virtual tape library says are already in 'scratch' status. I also had an interest in knowing how well compressed the data is on the virtual tape system.   I have not included the data step processing that follows this for  getting that mainframe list and the merge. Again, it all works. The entire program is also attached.   Can you suggest how to streamline the four PROC SQL steps?    This is SAS V9.4.   filename CATLIST "z:\mainframe\GPSE\Secure Agent\Reports\LISTCAT_HLQ_GPSEBKP"; filename OUTTAPES "z:\Mainframe\GPSE\Secure Agent\Reports\LISTCAT_TAPES.txt"; filename BLDNSCR "z:\Mainframe\GPSE\Secure Agent\IDCAMS_NSCR.txt"; /* ---------------------------------------------------------------------------- */ /* Part-1: Get the tape volumes and status from a SecureAgent generated report. */ /* The SecureAgent generated report is read in by the PROC IMPORT. */ /* ---------------------------------------------------------------------------- */ /* Import the All Volumes report. Note it is a CSV with column headings on line-1 */ /* ---------------------------------------------------------------------------- */ Proc Import datafile = "z:\mainframe\GPSE\Secure Agent\Reports\All Volumes_20230203.csv" out = Work.DSPL_CSV dbms = csv replace; getnames = yes; run; /* ---------------------------------------------------------------------------- */ /* Read all fields. Sum the CompressedSize and UncompressedSize fields */ /* Also determines the compression ratio */ /* ---------------------------------------------------------------------------- */ Proc SQL; create table Work.DSPL_TBL as select * from Work.DSPL_CSV; quit; /* ---------------------------------------------------------------------------- */ /* Determine the mean(Ratio) which is the overall compression ratio. */ /* ---------------------------------------------------------------------------- */ Proc SQL; title 'Sum of compression ratio'; create table Work.Compressed_Ratio as select sum(CompressedSize) as All_CompressedSize, sum(UncompressedSize) as All_UncompressedSize, TapeStatus from Work.DSPL_TBL where CompressedSize > 0 group by TapeStatus order by TapeStatus; quit; proc SQL; title 'Mean of Compressed and Uncompressed Sizes and Compression Ratios'; create table Work.Ratio as select All_CompressedSize, All_UncompressedSize, TapeStatus, (All_UncompressedSize / All_CompressedSize) as Ratio, mean(calculated Ratio) as Overall_Ratio from Work.Compressed_Ratio group by TapeStatus order by TapeStatus ; Quit; proc SQL; title 'Mean of Compressed and Uncompressed Sizes and Compression Ratios'; create table Work.Overall_Ratio as select All_CompressedSize, All_UncompressedSize, TapeStatus, Overall_Ratio, mean (Ratio) as Total_Ratio from Work.Ratio ; Quit;   Note that the above code works but I suspect it can all be done in one or two procs rather than the four I have here. ... View more