Hello,   If you only want to get rid of the minus sign when you display results in reports but without losing the information in the dataset, you can use a format as follows :   proc format; value noneg other=[abs()]; run; data have; x=-1; run; proc print data=have; format x noneg.; run; ... View more

Hint : read the error message then read the last lines of your code and try to figure out what is wrong. ... View more

Hello,   You wrote 'data' instead of '%macro'.   Also, you cannot display the macro code with a simple %put as it contains semi columns (you can use %quote to prevent them from being interpreted).   ... View more

File -> Save as... ? Please be more specific : what file do you want to create from which code ? ... View more

@Ronein,   The macro only contains one data step that compute the reduced amount for a given factor :     %macro mmacro(factor,run); data tttbl2_&run.; set tttbl1; Mis_New= min((Use*&factor.),Mis); sum_Mis+Mis; sum_Mis_New+Mis_New; Reduced_amount=sum_Mis-sum_Mis_New; call symputx("Reduced_amount",Reduced_amount,"G"); run; %mend; You can see that it contains your formula   Mis_New= min((Use*&factor.),Mis);   This macro is then used in the data history step, inside the do loop, for each tried value of the factor :   rc=dosubl(cats('%mmacro(',factor,',',run,');'));   dosubl is used since the reduced amount is computed in a separate data step.       ... View more

I don't know about efficiency but it surely seems clever to me the way you recompute the reduced amount variable at each step without having to re-read the whole dataset. ... View more

I can only give you one like unfortunately. ... View more

Hello,   Edit Removed my second answer as i am not sure it really made sense.   Something like this ?   %macro mmacro(factor,run); data tttbl2_&run.; set tttbl1; Mis_New= min((Use*&factor.),Mis); sum_Mis+Mis; sum_Mis_New+Mis_New; Reduced_amount=sum_Mis-sum_Mis_New; call symputx("Reduced_amount",Reduced_amount,"G"); run; %mend; %let MAXRUN=100; %let TARGET=200; %let PREC=1.0e-06; Data tttbl1; input ID Mis Use; cards; 1 100 90 2 150 130 3 800 300 4 250 200 5 1100 1000 6 950 900 7 890 800 8 250 240 9 590 530 10 700 600 ; Run; data history; stop=0; minfactor=1; maxfactor=10; do run=1 by 1 while(not stop and run<&MAXRUN.); if run=&MAXRUN. then put "WARNING: maximum number of runs reached"; factor=(minfactor+maxfactor)/2; rc=dosubl(cats('%mmacro(',factor,',',run,');')); Reduced_amount=symget("Reduced_amount"); put Reduced_amount=; if abs(Reduced_amount-&TARGET.)<&PREC. then stop=1; else if Reduced_amount<&TARGET. then do; action="The reduced amount is too small => we decrease the factor"; maxfactor_old=maxfactor; maxfactor=factor; end; else do; action="The reduced amount is too big => we increase the factor"; minfactor_old=minfactor; minfactor=factor; end; output; end; run;   ... View more