BookmarkSubscribeRSS Feed
Babloo
Rhodochrosite | Level 12

Appreciate if someone of you validate whether the following code respect to the SAS syntax? Since I do not have access to SAS enviornment at the moment I'm unable to validate it. As the following code has link statement, I'm not sure that the code which I updated is valid.

 

 

 

12 REPLIES 12
Allaluiah
Quartz | Level 8

If you honestly and sincerely wrote this code which one may agree considering your proc star status, nonetheless your question raises doubt whether you really wrote the code. On the other hand, supposing you did, what's the problem in checking syntax by yourself. 

 

With reference to many of your previous questions, I'm afraid the legitimacy of your questions seem very doubtful

Babloo
Rhodochrosite | Level 12

I've updated the code and not written the full code which was in OP. I have updated the same in OP.

data_null__
Jade | Level 19

I don't see any problems with your use of LINK.  I even use GOTO and all the kids think GOTO is taboo. 

 

There are a couple of things

   schrijfh:

         *schrijf weg met huidige gegevens;
         p2kbrn='7';

         if substr(khiref,1,1)  = '1' then
            do;
               file outfr14a noprint notitles; *File statement use redundand as FT14OUTH has file statement;
               link fr14outh;
            end;

         if substr(khiref,1,1)  = '2' then
            do;
               file outfr14b noprint notitles; *same redundand;
               link fr14outh;
            end;
         else if substr(khiref,1,1)  = '0' then
            do;
               file outfr14 noprint notitles; *same again;
               link fr14outh;
            end;

         return;
         fr14outh :   
            file '$FSAGDU/data/transport/out/qis_dwh/QISFR10_c.txt' lrecl=64;
         put @1   khiref   $20
            @21  kndbtpDB $10
            @31  knkbty   $2.
            @33  knkatv   $2.
            @35  knkath   $2.
            @37  knabew   3. 
            @40  psi      9. 
            @49  gnksec   $9.
            @58  agi      6. 
         ;
         output;  *remove you are using DATA _NULL_;
         return;
run;

I've commented about in the code here.  I think you have an unclosed DO block I'll see if I can figure that.

 

novinosrin
Tourmaline | Level 20

Good morning Guru @data_null__, Doesn't Goto 's return take you to the next iteration of the datastep as opposed to the link return?

 

Am i missing something in my understanding>?

data_null__
Jade | Level 19

@novinosrin wrote:

Good morning Guru @data_null__, Doesn't Goto 's return take you to the next iteration of the datastep as opposed to the link return?

 

Am i missing something in my understanding>?


LINK is GOTO and RETURN to jump point.

 

GOTO is just jump.

 

the HEADER= option in the FILE statement is an implied LINK.

 

the EOF= option in the INFILE statement is and implied GOTO.

 

I don't know if that helps. 🙂

 

 

Babloo
Rhodochrosite | Level 12
Is that OK if I remove file statement before PUT which was in the last step?
Patrick
Opal | Level 21

@Babloo

You really should do the first pass of unit testing yourself. This would show you that there is an unclosed DO block (=missing end statement).

 

Below...

          else knkbty='5';
          knkatv = '';
          knkath = '';
          link schrijfh;
        end;

      return;
      return;

Should be:

          else knkbty='5';
          knkatv = '';
          knkath = '';
          link schrijfh;
        end;

      end;
      return;

Also below bit looks to me logically not right:

        end;
      else if substr(khiref,1,1)  = '0' then
        do;
          file outfr14 noprint notitles;
          link fr14outh;
        end;

      return;
      fr14outh :   
        file '$FSAGDU/data/transport/out/qis_dwh/QISFR10_c.txt' lrecl=64;
      put @1   khiref   $20

You have code like file outfr14 noprint notitles; in your code (I assume that there is somewhere a filename statement which defines this fileref). You then link directly to fr14out where you issue another file statement - which will overwrite the previous file statement AND you always link to fr14out from your if/then/else blocks meaning that always the same code writing to the same file will get executed - which renders your if/then/else rather useless as they always result in identical code being executed.   

Babloo
Rhodochrosite | Level 12
In order to correct the logical error, can I remove the file statement
which I placed before the PUT statement?
data_null__
Jade | Level 19

@Allaluiah wrote:

If you honestly and sincerely wrote this code which one may agree considering your proc star status, nonetheless your question raises doubt whether you really wrote the code. On the other hand, supposing you did, what's the problem in checking syntax by yourself. 

 

With reference to many of your previous questions, I'm afraid the legitimacy of your questions seem very doubtful


@Allaluiah if your criticism of @Babloo is in regards to use of the LINK statement I suggest you are mistaken. 

VDD
Ammonite | Level 13 VDD
Ammonite | Level 13

I hope your future sake that you really don't update production code if you don't validate the logic yourself.

basic debuggers help to identify issues.  At times you can learn what the prior programmer was intending to do by stepping a few records through the logic.

https://communities.sas.com/t5/SAS-Programming/use-of-index/m-p/264460#M51865

 

Tom
Super User Tom
Super User

It is hard for me to read that hanging indentation style. For example you have indented lines after IF statements (so the structure implies you have added a DO block) but when I scan the left margin to find the corresponding END there is nothing before another statement starts on the same indentation as the IF.  That is not a problem per se, it just makes it harder to scan the code.

 

You do have one instance that looks strange where if you have 

if substr(khiref,1,1)  = '1' then
if substr(khiref,1,1)  = '2' then
else if substr(khiref,1,1)  = '0' then

Since the value cannot be both '1' and '0' it is probably ok, but it looks strange to not have ELSE before the second IF in that construct.

Babloo
Rhodochrosite | Level 12
I will try to add 'else' in the if clause. Is there any other which you
feel logically incorrect?

sas-innovate-2024.png

Don't miss out on SAS Innovate - Register now for the FREE Livestream!

Can't make it to Vegas? No problem! Watch our general sessions LIVE or on-demand starting April 17th. Hear from SAS execs, best-selling author Adam Grant, Hot Ones host Sean Evans, top tech journalist Kara Swisher, AI expert Cassie Kozyrkov, and the mind-blowing dance crew iLuminate! Plus, get access to over 20 breakout sessions.

 

Register now!

How to Concatenate Values

Learn how use the CAT functions in SAS to join values from multiple variables into a single value.

Find more tutorials on the SAS Users YouTube channel.

Click image to register for webinarClick image to register for webinar

Classroom Training Available!

Select SAS Training centers are offering in-person courses. View upcoming courses for:

View all other training opportunities.

Discussion stats
  • 12 replies
  • 1018 views
  • 1 like
  • 7 in conversation