Macro with %do loop and %if-%then/%else Statements won't populate values in data.

[jlc35]

I'm trying to do something similar to the following. I have data that is similar to the following (apologies, I'm not sure how best to format this in this forum:

SVI                                     Prop_Vax
Low Vulnerability                 .2300
High Vulnerability                .5000
Moderate Vulnerability        .4230

I am trying to create a macro, and as part of that macro, I want to have a data step that creates two new variables a "link" variable for a drill down graph, and a categorical SVI variable utilizing numbers rather than the full text value. Right now, I have the code as such:

%LET SVI1=Low Vulnerability;
%LET SVI2=Moderate Vulnerability;
%LET SVI3=High Vulnerability;

%macro COVID_Data;
data covid2;
set covid;
SVIcat2=.;
Link=" ";
%do i=1 %to 3;
%if SVI="&&SVI&i" %then SVIcat2=i;
%else %if SVI=" " %then SVIcat2=.;
%end;
%do i=1 %to 3;
%if SVI="&&SVI&i" %then link="vuln&i..html";
%else %if SVI=" " %then link=" ";
%end;
run;
%mend COVID_Data;

However, when I run the macro, it doesn't actually produce values in the columns for the "SVIcat2" and "Link" variables, and I can't figure out why. Can someone explain what I am doing incorrectly?

[WarrenKuhfeld]

Use the DATA step and arrays, not macros for this. Understand that the macro processing executes first, before the data are read.

[Kurt_Bremser]

A condition like this

%if SVI="&&SVI&i"

can NEVER be true, as the text SVI can never be equal to a text containing quotes, no matter what the macro variables resolve to.

The mistake comes from the misunderstanding of what a macro does, and when it does it. The macro can never have access to data that will be present once the code executes after the macro created it. You cannot use values in variables that will be present only once the data step created by the macro is compiled and executed.

Macro is for handling code, not for handling data. Print that on a large sheet in very large letters and fix it above your desk.