Importing All CSV in Directory and %IF macro statements

[raivester]

I am trying to read in all CSV files within a directory (I am using this page as a guide for my code: SAS Help Center: Example 1: Import All CSV Files That Exist within a Directory). Below is the code I am running and the errors I am getting. Can someone help me resolve these errors?

%macro retrieve(dir,ext);
	%local cnt infile rc did memcnt name;
	%let cnt=0;

	%let infile=S:\Projects\Data\Annual_Submissions\2019\Raw\State\City\Original downloads;
	%let rc=%sysfunc(filename(infile,&dir));
	%let did=%sysfunc(dopen(&infile));
 	  %if &did ne 0 %then do;
	%let memcnt=%sysfunc(dnum(&did));

	  %do i=1 %to &memcnt;

	    %let name=%qscan(%qsysfunc(dread(&did,&i)),-1,.);

		  %if %qupcase(%qsysfunc(dread(&did,&i))) ne %qupcase(&name) %then %do;
      	    %if %superq(ext) = %superq(name) %then %do;      
				%let cnt=%eval(&cnt+1);
				%put %qsysfunc(dread(&did,&i));
				proc import datafile="&&infile\%qsysfunc(dread(&did,&i))" out=tx&cnt 
					dbms=csv replace;
					guessingrows=10000; getnames=yes;
				run;
			%end;
		   %end;

		  %end;
		    %end;
		%else %put &dir cannot be opened.;
  		%let rc=%sysfunc(dclose(&did)); 

%mend retrieve;

The errors I am getting:

ERROR: There is no matching %DO statement for the %END. This statement will be ignored.
612          %else %put &infile cannot be opened.;
ERROR: There is no matching %IF statement for the %ELSE.
ERROR: A dummy macro will be compiled.
613          %let rc=%sysfunc(dclose(&did));

[ballardw · Accepted solution]

Are these files all of the same structure? If so you will be WAY better off writing a data step to read them so the results are consistent instead of Proc Import which make guesses for each file about length and type of variable.

One might suspect from the path you show the data contains text about cities. If each file represents a different "city" then it is extremely likely that the length of the city variable will differ a lot between files and if you intend to combine any of these you will be spending time "fixing" things that should be the same.

Best would be to have a document from the source that describes the column contents so you can set the length and type.

When you delve into macro programming you will want to learn to use the options Mprint and possiblly Mlogic and Symbolgen to display the code generated and so the ERRORS end up in better relation to your code.

Start with

%let infile=S:\Projects\Data\Annual_Submissions\2019\Raw\State\City\Original downloads;
	%let rc=%sysfunc(filename(infile,&dir));
	%let did=%sysfunc(dopen(&infile));
 	  %if &did ne 0 %then do;
	%let memcnt=%sysfunc(dnum(&did));

 That hightlighted "do" should be "%do".

[raivester]

Thank you this seemed to have resolved those errors! However, when I run

%retrieve(&fileref.,csv);

I now get:

NOTE: In a call to the DOPEN routine, the fileref
S:\Projects\Data\Annual_Submissions\2019\Raw\State\City\Original downloads
exceeds 8 characters, and will be truncated.
S:\Projects\Data\Annual_Submissions\2019\Raw\State\City\Original downloads cannot
be opened.

[raivester]

Actually, I'm using 

%retrieve(&infile.,csv);

Apologies.

[ballardw]

Please examine these two lines of code:

	%let rc=%sysfunc(filename(infile,&dir));
	%let did=%sysfunc(dopen(&infile));

You created a fileref name INFILE then used the macro variable &INFILE, not the fileref.