Help using Base SAS procedures

Nested do loops to compare two sets of variables

Accepted Solution Solved
Reply
New Contributor
Posts: 2
Accepted Solution

Nested do loops to compare two sets of variables

Hi!

I have a dataset where each row is a different person and each column is the date that they visited the study site.

I have list of variables: Pdate1-Pdate1360 and Qdate1-Qdate705. I want to create a flag variable called Flagvar that indicates whether any of the Q dates fell within 30 days of any of the Pdates, but I’m new to arrays and not sure where I’m going wrong. Since I already have over 2000 columns I don't want to create a cartesian product. Here is my code:

data want; set have;

      array Pdate{1360} Pdate1-Pdate1360;

      array Qdate{705} Qdate1-Qdate705;

            do k=1 to 1360;

            do j=1 to 705;

            if intck('day', Pdate{k}, Qdate{j}) le 30

                  then Flagvar=1;

                  else Flagvar=0;

            end;

      end;

run;

 

Suggestions, please?

Thanks in advance! I'm using SAS 9.4.


Accepted Solutions
Solution
‎01-20-2017 08:20 AM
Super User
Posts: 17,819

Re: Nested do loops to compare two sets of variables

Remove the Else condition from your loop. The Else resets the flag as soon as you check the next field. 

 

You may also want to add a LEAVE so you leave the loop when the flag is set to speed this up. Or a while condition to the loop. 

 

Yoir logic and code appears fine otherwise Smiley Happy 

 

 

View solution in original post


All Replies
Solution
‎01-20-2017 08:20 AM
Super User
Posts: 17,819

Re: Nested do loops to compare two sets of variables

Remove the Else condition from your loop. The Else resets the flag as soon as you check the next field. 

 

You may also want to add a LEAVE so you leave the loop when the flag is set to speed this up. Or a while condition to the loop. 

 

Yoir logic and code appears fine otherwise Smiley Happy 

 

 

Super User
Posts: 5,081

Re: Nested do loops to compare two sets of variables

Another issue you may need to address ...

 

Even with ELSE removed, this code gives you the wrong answer.  It properly handles PDates that come before QDates, but not the other way around.  For those cases, INTCK will give you a negative number, which is always less than 30.

 

When measuring days, INTCK isn't really needed.  You can just subtract one from the other.  This might be a better calculation to use:

 

abs(Pdate{k} - Qdate{k})

 

Even then, be wary of missing values which will also be less than 30.

New Contributor
Posts: 2

Re: Nested do loops to compare two sets of variables

That's a very good point - thanks!
☑ This topic is SOLVED.

Need further help from the community? Please ask a new question.

Discussion stats
  • 3 replies
  • 405 views
  • 3 likes
  • 3 in conversation