DATA Step, Macro, Functions and more

Expected close parenthesis error in loop over macro

Accepted Solution Solved
Reply
Frequent Contributor
Posts: 78
Accepted Solution

Expected close parenthesis error in loop over macro

I am getting a:

 

Expected close parenthesis after macro function invocation not found

 

fro this code:

 

data _null_;
  set LoopData;
  call execute('%nrstr(%SomeMacro('||ColumnName||'))');
run;

Cannot see anything wrong. Any ideas?


Accepted Solutions
Solution
‎06-22-2017 03:24 PM
PROC Star
Posts: 1,237

Re: Expected close parenthesis error in loop over macro

Agree, that bit looks fine.  Maybe there's a problematic macro call inside of %SomeMacro, or maybe your ColumnName variable has an unmatched open parenthesis in it. 

 

I tested your code with below, and worked fine:

 

%macro somemacro(columnName);
  proc print data=sashelp.class;
    var &columnName;
  run;
%mend somemacro;

data loopdata;
  input columnName $8.;
  cards;
sex
weight
height
;
run;

data _null_;
  set LoopData;
  call execute('%nrstr(%SomeMacro('||ColumnName||'))');
run;

 

I would try calling %SomeMacros manually (i.e., without CALL EXECUTE), and make sure it works.  Then I would look at all the values in ColumnName to check for any surprises.

View solution in original post


All Replies
Solution
‎06-22-2017 03:24 PM
PROC Star
Posts: 1,237

Re: Expected close parenthesis error in loop over macro

Agree, that bit looks fine.  Maybe there's a problematic macro call inside of %SomeMacro, or maybe your ColumnName variable has an unmatched open parenthesis in it. 

 

I tested your code with below, and worked fine:

 

%macro somemacro(columnName);
  proc print data=sashelp.class;
    var &columnName;
  run;
%mend somemacro;

data loopdata;
  input columnName $8.;
  cards;
sex
weight
height
;
run;

data _null_;
  set LoopData;
  call execute('%nrstr(%SomeMacro('||ColumnName||'))');
run;

 

I would try calling %SomeMacros manually (i.e., without CALL EXECUTE), and make sure it works.  Then I would look at all the values in ColumnName to check for any surprises.

Frequent Contributor
Posts: 78

Re: Expected close parenthesis error in loop over macro

Thanks I removed brackets from ColumnName because I thought exactly this. Turned out to be some legacy being commented out which screwed the code.
Super User
Super User
Posts: 6,502

Re: Expected close parenthesis error in loop over macro

Personally when using CALL EXECUTE() to generate macro calls I wrap the %NRSTR() macro function just around the macro name itself and leave the macro parameters without macro quoting.

 

data _null_;
  set LoopData;
  call execute(cats('%nrstr(%SomeMacro)(',ColumnName,')'));
run;

Are you sure that the value of ColumnName does not contain '()' characters?

☑ This topic is solved.

Need further help from the community? Please ask a new question.

Discussion stats
  • 3 replies
  • 136 views
  • 1 like
  • 3 in conversation