topic Re: no change in main file in SAS Programming

no change in main file

mahfuz_pops — Tue, 29 Dec 2015 01:57:47 GMT

Hi I have imported a data file from CSV fromat which have 28243 rows and 2296 varables using following code:

PROC IMPORT OUT= Ggp1

DATAFILE="G:\seleg.csv"

DBMS=csv REPLACe;

GETNAMES=YES;

DATAROW=2;

guessingrows=32767

Run;

Now I'm running follwong code:

data work.Ggp1;

set work.Ggp1;

array _v{*} v:;

if x1 > 1 then

do i = max(815,x1) to min(dim(_v),xx1);

_v{i} = 2;

end;

drop i;

run;

the log shows that the program has run successfully and shows no error message. But I check the data file, I don't see any change in the data file, can you tell my how to fix this problem?

Re: no change in main file

Reeza — Tue, 29 Dec 2015 02:44:18 GMT

I would recommend changing the second step such that it creates a new data set, not overwriting the imported data set and then checking.

Please post the log, one check is to make sure your loop condition is ever executed.

data work.check_condition1;
set work.Ggp1;
if x1 > 1 then output;
run;

Re: no change in main file

Astounding — Tue, 29 Dec 2015 03:08:30 GMT

There's one additional check to make, concerning this range:

do i = max(815,x1) to min(dim(_v),xx1);

Have you checked that max(815,x1) is actually less than or equal to min(dim(_v),xx1) ??

Re: no change in main file

mahfuz_pops — Tue, 29 Dec 2015 03:56:20 GMT

yep, x1 is less than or equal to xx1.

Re: no change in main file

mahfuz_pops — Tue, 29 Dec 2015 04:00:59 GMT

hi,

thanks a lot. the attachment contains the CSV file, would you pls check that? mainly I intended to recode the variavbles starts from v815 to v1360, depending the values of x1 and xx1.

Re: no change in main file

mahfuz_pops — Tue, 29 Dec 2015 04:03:13 GMT

hi, the attachment contains the CSV data file.

Re: no change in main file

mahfuz_pops — Tue, 29 Dec 2015 04:35:53 GMT

I have created new file instead of reqriting, still there is no change.....actually, if we run the code, the output file should contain 2 instead of 1 from colomn no. 941 to 945 in row 36.

Re: no change in main file

mahfuz_pops — Tue, 29 Dec 2015 04:47:02 GMT

the log:

data sasuser.ggp2;
2472 set sasuser.ggp1;
2473 array _v{*} v:;
2474 if x1 > 1 then
2475 do i = max(815,x1) to min(dim(_v),xx1);
2476 _v{i} = 5;
2477 end;
2478 drop i;
2479 run;

NOTE: There were 474 observations read from the data set SASUSER.GGP1.
NOTE: The data set SASUSER.GGP2 has 474 observations and 671 variables.
NOTE: DATA statement used (Total process time):
real time 0.03 seconds
cpu time 0.04 seconds

2480 data work.check_condition1;
2481 set sasuser.ggp1;
2482 if x1 > 1 then output;
2483 run;

NOTE: There were 474 observations read from the data set SASUSER.GGP1.
NOTE: The data set WORK.CHECK_CONDITION1 has 37 observations and 671 variables.
NOTE: DATA statement used (Total process time):
real time 0.02 seconds
cpu time 0.03 seconds

Re: no change in main file

Reeza — Tue, 29 Dec 2015 05:14:34 GMT

No attachment...perhaps its being virus checked.

Re: no change in main file

Reeza — Tue, 29 Dec 2015 06:23:44 GMT

I think the other suggestion of the do loop conditions is correct, once your log is examined.

Your log shows 671 variables. So I have no idea what X1 is, but assuming it takes a value within the range of 1 to 671 the max condition always evaluates to 815 and then whatever the lower interval is, but that loop will never execute. Test the condition again with a put statement.

do i = max(815,x1) to min(dim(_v),xx1);

NOTE: The data set SASUSER.GGP2 has 474 observations and 671 variables.

Check the log to see if the loop is ever entered. You could also need a BY -1 if you plan to count down, but then I think the variable i won't be a valid index for your array.

data sasuser.ggp2;
set sasuser.ggp1;
array _v{*} v:;
if x1 > 1 then
do i = max(815,x1) to min(dim(_v),xx1);
 _v{i} = 5;
put 'In Do Loop';
 end;
 drop i;
run;

Re: no change in main file

Astounding — Tue, 29 Dec 2015 13:45:29 GMT

It's not enough to verify that x1 <= xx1.

Even when x1 <= xx1, the DO loop may be starting at 815, not at x1.

You have to check for the actual conditions that your program uses. Are there any observations where:

max(815,x1) <= min(dim(_v),xx1)

Re: no change in main file

mahfuz_pops — Wed, 30 Dec 2015 02:43:26 GMT

I'm really very new, would u please tell me what does max(815,x1) mean practically?

Re: no change in main file

mahfuz_pops — Wed, 30 Dec 2015 02:55:50 GMT

wha does the hole statement mean? max(815,x1) <= min(dim(_v),xx1)

Re: no change in main file

Reeza — Wed, 30 Dec 2015 03:48:08 GMT

Max is a function, that takes the maximum of the two arguments.

In this case for every row, it evaluates to the maximum of 815 and the value of X1 variable.

If you don't know what the parts mean, break out the code so you can examine it line by line. Here's an example. Look at the values that the check_flag's take over your data set, specifically what the start and ending for the do loop would be, and if they're what you intended.

data sasuser.ggp2;
set sasuser.ggp1;
array _v{*} v:;
if x1>1 then check_flag1=1;
else check_flag1=0;
check_flag2=max(815, x1);
check_flag3=min(dim(_v), xx1);
check_flag4=dim(_v);

run;

Re: no change in main file

mahfuz_pops — Wed, 30 Dec 2015 08:19:01 GMT

thanks a lot, thank you very much for your cooperaion.....

Re: no change in main file

Astounding — Wed, 30 Dec 2015 15:03:50 GMT

As Reeza mentioned, max(815, x1) means whichever is larger (815 or x1).

Similary, min takes whichever is smaller (but omits missing values). So min(dim(_v), xx1) means take whichever is smaller, either the number of elements in the array or the value of xx1.