topic Re: This %Let definition runs fine but the %Macro definition does not run Please help with this in SAS Programming

This %Let definition runs fine but the %Macro definition does not run Please help with this

hmlong25 — Fri, 31 Jan 2025 19:02:27 GMT

%let type=Gold;
title "&type Customers";
proc sql number;
select Name, Age_Group, Type
from mc1.customers
where Type contains "&type";
quit;
title;

%macro customers(type);
title "&type Customers";
proc sql number;
select Name, Age_Group, Type
from mc1.customers
where type="%upcase(&type)";
quit;
title;
%mend customers;

%customers(Gold)

Re: This %Let definition runs fine but the %Macro definition does not run Please help with this

Tom — Fri, 31 Jan 2025 20:44:17 GMT

In the first program you are generating this WHERE clause:

where Type contains "Gold"

In the second one you generate this WHERE clause instead:

where type = "GOLD"

So you should see different results. The only value that satisfies the second test is GOLD which does not contain any lowercase letters and so could not contatin Gold.

Re: This %Let definition runs fine but the %Macro definition does not run Please help with this

A_Kh — Fri, 31 Jan 2025 19:35:46 GMT

It's most likely uppercase is used in the macro definition (where type="%upcase(&type)").
Check your data, look at your first sql step that works with %let statement.
Try this:

%macro customers(type);
title "&type Customers";
proc sql number;
select Name, Age_Group, Type
from mc1.customers
where type="&type";
quit;
title;
%mend customers;


%customers(Gold);