topic Re: what's wrong with the following macro function and its invocation? in SAS Programming

what's wrong with the following macro function and its invocation?

Newlifewithegg — Fri, 06 Oct 2023 18:06:54 GMT

I am using the online sas studio.

The code is as follows,

%macro allcylinders;
proc sql noprint;
select distinct Cylinders
into :val1-
from sashelp.cars
where Cylinders ne .;
quit;

%put &=SQLOBS;

%do i=1 %to %SQLOBS;
title "&&val%i-Cylinder Cars";
proc print data=sashelp.cars noobs;
var Make Model Type Origin MSRP MPG_City MPG_Highway;
where Cylinders=&&val&i;
run;
%end;
%mend allcylinders;


%allcylinders

The macro compilation passes successfully. When I run the macro, it complains the following,

SQLOBS=7

WARNING: Apparent invocation of macro SQLOBS not resolved.
ERROR: A character operand was found in the %EVAL function or %IF condition where a numeric operand is required. The condition was:
%SQLOBS
ERROR: The %TO value of the %DO I loop is invalid.

But as I printed on the screen, the macro variable SQLOBS=7, thus I don't understand why it issues the specific WARNING, and then give the next ERROR message.

Re: what's wrong with the following macro function and its invocation?

PaigeMiller — Fri, 06 Oct 2023 18:13:08 GMT

%do i=1 %to %SQLOBS;

should say

%do i=1 %to &SQLOBS;

Re: what's wrong with the following macro function and its invocation?

A_Kh — Fri, 06 Oct 2023 18:20:05 GMT

and also,

title "&&val%i-Cylinder Cars";
needs to be 
title "&&val&i-Cylinder Cars";

Re: what's wrong with the following macro function and its invocation?

Tom — Fri, 06 Oct 2023 19:04:23 GMT

There are two trigger characters that the macro processor looks for to decide if it should intervene.

The & is used for referencing macro variables (aka SYMBOLS).

The % is used for macro statements, functions and user defined macros.

You tried to call a macro named SQLOBS instead of reference the value of a macro variable named SQLOBS.

Re: what's wrong with the following macro function and its invocation?

Newlifewithegg — Fri, 06 Oct 2023 20:41:17 GMT

Thank all for your help! Feel so ashamed to have made so stupid mistakes ...

Re: what's wrong with the following macro function and its invocation?

Newlifewithegg — Fri, 06 Oct 2023 20:42:22 GMT

sorry, don't know how to accept more than one solution ..