topic Re: How do I fix my macro in SAS Programming

How do I fix my macro

TXSASneophyte — Fri, 26 Feb 2016 22:51:19 GMT

Hello Everyone,

I am trying to create a macro for this calculation I am doing for several datasets but just can't seem to get my code to work. Here's some information you might need if you want to help me.

Library name: Diabetes

Datasets = FFYEAR09 FFYEAR10 FFYEAR11 FFYEAR12 FFYEAR13 FFYEAR14 FFYEAR15

Here is the original code I want to use in a macro; it works when I do it individually for a dataset.

DATA DIABETES.FFYEAR09 (KEEP=RECIPIENT_NBR ALLMEDS TOTALQNT OCTMEDS OCTQNT);

SET DIABETES.FFYEAR09;

BY RECIPIENT_NBR NDC;

RETAIN ALLMEDS TOTALQNT OCTMEDS OCTQNT;

IF FIRST.RECIPIENT_NBR THEN DO;

ALLMEDS = 0;

TOTALQNT = 0;

OCTMEDS = 0;

OCTQNT = 0;

END;

IF FIRST.NDC THEN DO;

ALLMEDS + 1;

TOTALQNT + RX_QUANTITY;

IF MONTH (RX_FILL_DT) = 10 THEN DO;

OCTMEDS + 1;

OCTQNT + RX_QUANTITY;

END;

IF LAST.RECIPIENT_NBR THEN OUTPUT;

LABEL ALLMEDS = 'TOTAL NUMBER OF MEDICATIONS'

TOTALQNT = 'TOTAL QUANTITY OF PILLS'

OCTMEDS = 'TOTAL NUMBER OF MEDICATIONS IN OCTOBER'

OCTQNT = 'TOTAL QUANTITY OF PILLS IN OCTOBER';

RUN;

I am fairly new to the world of SAS and this is my first attempt at a macro. This is the macro I developed based on some information I found online for macro beginners.

%MACRO TOTALMEDS;

%DO I=1 %TO 7;

DATA = DIABETES.FFYEAR&I (KEEP=RECIPIENT_NBR ALLMEDS TOTALQNT OCTMEDS OCTQNT);

BY RECIPIENT_NBR NDC;

RETAIN ALLMEDS TOTALQNT OCTMEDS OCTQNT;

IF FIRST.RECIPIENT_NBR THEN DO;

ALLMEDS = 0;

TOTALQNT = 0;

OCTMEDS = 0;

OCTQNT = 0;

END;

IF FIRST.NDC THEN DO;

ALLMEDS + 1;

TOTALQNT + RX_QUANTITY;

IF MONTH (RX_FILL_DT) = 10 THEN DO;

OCTMEDS + 1;

OCTQNT + RX_QUANTITY;

END;

IF LAST.RECIPIENT_NBR THEN OUTPUT;

LABEL ALLMEDS = 'TOTAL NUMBER OF MEDICATIONS'

TOTALQNT = 'TOTAL QUANTITY OF PILLS'

OCTMEDS = 'TOTAL NUMBER OF MEDICATIONS IN OCTOBER'

OCTQNT = 'TOTAL QUANTITY OF PILLS IN OCTOBER';

RUN;

%MEND TOTALMEDS;

MPRINT (TOTALMEDS): PROC PRINT DATA=DIABETES.FFYEAR&I;

%TOTALMEDS

So something tells me I got the first statement after the "%Do I=1 …" wrong, and I am not sure where "MPRINT" is supposed to go for SAS to tell me exactly where I am messing up. Is there a more complicated macro I'm supposed to use?

If anyone can please shed some light on this, I would greatly appreciate your help!

I am using SAS 9.2

Re: How do I fix my macro

LinusH — Fri, 26 Feb 2016 23:02:49 GMT

Missing the %end; ?

Re: How do I fix my macro

Reeza — Sat, 27 Feb 2016 01:45:04 GMT

If your data goes from 9 to 15 why are you looping from 1 to 7?

Loop from 9 to 15 and use z2. Format so that the 9 converts to 09.

On top of the solution to add %end.

Re: How do I fix my macro

Astounding — Sat, 27 Feb 2016 03:30:15 GMT

There shouldn't be an equals sign in a DATA statement. Your original code doesn't use one, but somehow the macro added one:

DATA = DIABETES.FFYEAR&I (KEEP=RECIPIENT_NBR ALLMEDS TOTALQNT OCTMEDS OCTQNT);

Re: How do I fix my macro

FreelanceReinh — Sat, 27 Feb 2016 10:51:35 GMT

Moreover, the SET statement is missing in your macro. For completeness (and good programming practice), I would also suggest to include a %LOCAL statement.

So, to put everything together, the macro should have the following structure:

%macro totalmeds;
%local i;
%do i=9 %to 15;
  data diabetes.ffyear%sysfunc(putn(&i,z2.))(keep=recipient_nbr allmeds totalqnt octmeds octqnt);
  set diabetes.ffyear%sysfunc(putn(&i,z2.));
  by ...
  ...
  run;
%end;
%mend totalmeds;

That said, it seems unusual to me that permanent datasets with detail data are overwritten with datasets containing only aggregated data. (I worked on a diabetes project.) But I assume you know what you're doing and the lost information is still available somewhere else.

Re: How do I fix my macro

TXSASneophyte — Thu, 03 Mar 2016 15:12:09 GMT

Thank you so much for the help! Your solution got the macro humming along just nicely 🙂

Despite the name of the library, this is just exploratory temporary data files I'm working with and creating. My computer has very little free memory that storing the datasets in the "work" library would eat up all my free space. Instead, I put everything on an external hard drive, so my "diabetes" folder is just serving as a temporary folder. But I do appreciate your concern! Since you've worked with diabetes data, I may ask you for your lessons-learned in the future!