topic Re: Why OR operator doesn't works properly inside IF THEN statements? in SAS Programming

Why OR operator doesn't works properly inside IF THEN statements?

tpchaudhary — Fri, 19 Mar 2021 04:41:18 GMT

Hi There,

In below example, I would like to get missing ID values which is not matched with my assigned value in macro variable. I know I can perform this task as I did in my Query2 to get correct output, but I don't understand about what's wrong in my Query1.

Can someone explain me why query1 in my below piece of code is not giving desired output?

/****************************************************************************************/

data ID_Table;
input ID $10.;
cards;
1000000001
1000000002
1000000003
;run;

%let IDN1 = 1000000001;
%let IDN2 = 1000000002;

/*Query1*/
data Missing_ID_Wrong_Output;
set ID_Table;
IDN1=input(&IDN1.,best12.);
IDN2=input(&IDN2.,best12.);
if (ID ne IDN1 OR ID ne IDN2) then output;
keep ID;
run;
proc print data=Missing_ID_Wrong_Output noobs;run;
/*
ID
1000000001
1000000002
1000000003
*/

/*Query2*/
data Missing_ID_Correct_Output;
set ID_Table;
if ID not in (&IDN1., &IDN2.) then output;
run;
proc print data=Missing_ID_Correct_Output noobs;run;
/*
ID
1000000003
*/

/****************************************************************************************/

Re: Why OR operator doesn't works properly inside IF THEN statements?

japelin — Fri, 19 Mar 2021 05:19:32 GMT

If fix below, you can get correct output.

if (ID ne IDN1 AND ID ne IDN2) then output;

Re: Why OR operator doesn't works properly inside IF THEN statements?

Astounding — Fri, 19 Mar 2021 08:02:11 GMT

As was suggested, you need to change OR to AND. however, there is also another issue. You have ignored messages in the log about numeric to character conversion when using the INPUT function. The best solution would eliminate the INPUT function entirely.

if ID ne &IDN1 and ID ne &IDN2 then output;

Re: Why OR operator doesn't works properly inside IF THEN statements?

tpchaudhary — Fri, 19 Mar 2021 13:23:11 GMT

Thanks folks for quick respond with perfect solution!