topic Re: Is the macro correct? in SAS Programming

Is the macro correct?

MikeTurner — Thu, 30 Aug 2012 05:46:12 GMT

I wrote the macro indd and I'm wondering why the macro can't be resolved when I call the macro by: %put i'm running %indd(no).

Is there something wrong with the macro? Thanks in advance.

%macro indd(in);

%if %upcase(&in)=YES %THEN %do;

%end;

%else %do;

noint

%end;

%mend;

%put i'm running %indd(no);

Re: Is the macro correct?

MikeTurner — Thu, 30 Aug 2012 06:19:12 GMT

I tried the codes on my colleague's computer and it worked fine. But not on my computer. It's so weird.

Re: Is the macro correct?

Ksharp — Thu, 30 Aug 2012 06:41:16 GMT

Due to this special single quote : i'm running

%macro indd(in);

%if %upcase(&in)=YES %THEN %do;

 yes

%end;

%else %do;

noint

%end;

%mend;

option mprint symbolgen mlogic; 

%put  %str(i%'m running) %indd(no) ;

Ksharp

Re: Is the macro correct?

MikeTurner — Thu, 30 Aug 2012 06:59:10 GMT

Thank you, Ksharp.

I tried your codes and still didn't work. I suspected something wrong with my computer's setting.

I tried your codes and my codes on my colleague's computer and all worked fine.

Thanks.

Re: Is the macro correct?

Ksharp — Thu, 30 Aug 2012 07:07:07 GMT

It is so weird .Did you open a new sas session ? What is your log ?

Re: Is the macro correct?

DanielSantos — Thu, 30 Aug 2012 08:35:58 GMT

Runs fine. Nothing wrong about your code.

Please share the log and context of your session.

Cheers from Portugal.

Daniel Santos @ www.cgd.pt

Re: Is the macro correct?

MikeTurner — Thu, 30 Aug 2012 08:47:57 GMT

I opened a new sas session. It seemed that the codes sometimes worked fine and sometimes not. Please have a look at the log. Thank all.

16 %macro indd(in);

17 %if %upcase(&in)=YES %THEN %do;

19 %end;

20 %else %do;

21 noint

22 %end;

23 %mend;

15 %put i'm running %indd(no);

---------------------

NOTE 49-169: The meaning of an identifier after a quoted string might change in a future SAS

release. Inserting white space between a quoted string and the succeeding

identifier is recommended.

24 option mprint symbolgen mlogic;

25 %put i'm running %indd(no);

MLOGIC(INDD): Beginning execution.

MLOGIC(INDD): Parameter IN has value no

SYMBOLGEN: Macro variable IN resolves to no

MLOGIC(INDD): %IF condition %upcase(&in)=YES is FALSE

MLOGIC(INDD): Ending execution.

i'm running %indd(no);%macro indd(in);%if %upcase(&in)=YES %THEN %do;%end;%else

%do;noint%end;%mend;option mprint symbolgen mlogic;%put i'm running noint

26 %put i'm running %indd(no);

Re: Is the macro correct?

DanielSantos — Thu, 30 Aug 2012 10:41:45 GMT

OK, I got it.

Code tested was actually the one Ksharp posted, which runs fine.

It's the ' char inside the %put

It's totally messing the compiler, that's why you get erratic runs.

As Ksharp suggested, enclose it inside a masking macro functions so the compiler can get the code right.

%str(%')