topic Re: 1 Unclosed Select Block in SAS Programming

1 Unclosed Select Block

ManitobaMoose — Sat, 14 Apr 2018 00:42:01 GMT

Libname Learn'/folders/myfolders/SASData' ; 

Data Sales(keep = Date Amount) Inventory(keep = Partnumber Quantity) ; 
	infile '/folders/myfolders/SASData/mixed_recs.txt'  pad ; 
	Input @16 Code 2. @ ;
	If Code eq 1 then do ; 
		Out = Sales ;
		input @1 Date mmddyy10. 
		      @12 Amount 4.  ; 
		format Date mmddyy10. ;   
	end ; 
		
	
	Else if Code ne 1 then do ;
		Out = Inventory ;
		input @1 PartNumber $ 6.
		      @8 Quantity 3. ; 
	end ; 
run ; 

Data Sales_Only ; 
	Set Sales ; 
	Select ; 
	When (Missing(Date)) New = 1 ; 
	When (Not Missing(Date)) New = 2 ; 
	When (Missing(Amount)) New = 3 ;
	When (Not Missing(Amount)) New = 4 ; 
	Otherwise ; 
run ;

Not sure where this is unclosed? Tx.

Re: 1 Unclosed Select Block

novinosrin — Sat, 14 Apr 2018 00:49:08 GMT

I think you missed an END

Data Sales_Only ; 
	Set Sales ; 
	Select ; 
	When (Missing(Date)) New = 1 ; 
	When (Not Missing(Date)) New = 2 ; 
	When (Missing(Amount)) New = 3 ;
	When (Not Missing(Amount)) New = 4 ; 
	Otherwise ; 
end;
run ;

Re: 1 Unclosed Select Block

Kurt_Bremser — Sat, 14 Apr 2018 04:42:55 GMT

Maxim 1: Read the documentation.

http://documentation.sas.com/?cdcId=pgmsascdc&cdcVersion=9.4_3.3&docsetId=lestmtsref&docsetTarget=p09213s9jc2t99n1vx0omk2rh9ps.htm&locale=de

SAS 9.4 and Viya 3.3 Programming Documentation - Data Step Programming - Data Step Statements - Dictionary of D. S. Statements

The presence of the necessary end; statement is prominent in the syntax section.

There is a very strong reason why Maxim 1 is actually the first.

Re: 1 Unclosed Select Block

Kurt_Bremser — Mon, 16 Apr 2018 06:49:22 GMT

And you should start writing code in a visually ordered style:

Data Sales_Only ; 
  Set Sales ; 
  Select ; 
    When (Missing(Date)) New = 1 ; 
    When (Not Missing(Date)) New = 2 ; 
    When (Missing(Amount)) New = 3 ;
    When (Not Missing(Amount)) New = 4 ; 
    Otherwise ; 
  end;
run ;