topic Re: what's wrong with this macro code in New SAS User

what's wrong with this macro code

juliajulia — Fri, 15 Oct 2021 18:32:30 GMT

can somebody help me take a look at the following macro code to see what's wrong with it. i can run the proc tabulate without macro and no error but when i put it to the macro, it give me the syntax error message:

without macro (no error):

proc tabulate data=adr.clientinfo2019 format=8.1;
class age race ;
table age='' all={label="Subtotal"}, race*(n="No." colpctn="col Percent" ) all={label="Total"} / printmiss box="";
format age age2fmt.;
run;

/***has error when i run the following code**/

%macro colT(dset,colvar,var);
proc tabulate data=&dset. format=20.4;
class &colvar &var ;
table &var.="" all={label="Subtotal"}, &colvar*(n="No." colpctn="Col Percent") ;
run;
%mend colT;
%colT (data, racee age) ;

error message:

NOTE: Line generated by the invoked macro "COLT".
1 proc tabulate data=&dset. format=20.4; class &colvar &var ; table &var.=""
-----
180
1 ! all={label="Subtotal"}, &colvar*(n="No." colpctn="Col Percent") ; run;
ERROR 180-322: Statement is not valid or it is used out of proper order.

Re: what's wrong with this macro code

Quentin — Fri, 15 Oct 2021 18:38:34 GMT

Look like you might be missing a comma in the macro call. Did you mean:

%colT (data, racee, age)

Re: what's wrong with this macro code

ballardw — Fri, 15 Oct 2021 19:16:04 GMT

You can see more details of problems by setting Options mprint (and sometimes mlogic and symbolgen) before running the macro with problems.

options mprint;

%colT (data, racee age) ;

options nomprint;

In this case if that is the code you submitted then @Quentin is correct. You did not pass a value for the VAR parameter and so you would get a table statement that looks like:

table  ="" <other stuff>

When pasting text copied from the log you should open a text box on the forum using the </> icon that appears above the message window and paste the copied text there. The message windows reformat text so the diagnostic characters like the underscores do not appear where they actually did in the log window.

Re: what's wrong with this macro code

juliajulia — Fri, 15 Oct 2021 20:01:02 GMT

oh, i missed a comma between the %colT (data, raceeth, age) . Thank you so much.