topic Re: Error using if then else loop in New SAS User

Error using if then else loop

SAS_New_User1 — Fri, 22 Jan 2021 21:23:53 GMT

I am running the below query and I keep getting the error

data A;

set B;

length str_2 $1000

(

startpos = index(str_1, "START")

and

endpos - index(str_1, "STOP")

)

then

str_2 = substr(str, startpos+7, endpos-(startpos+7));

str_1 = cats(substr(str_1, 1, startpos), substr(str_1, endpos));

else str_1;

run;

I am getting the below error:

Error: No matching ID-THEN clause

Error: Statement is not valid or it is not used out of proper order.

What am I doing wrong?

Re: Error using if then else loop

Kurt_Bremser — Fri, 22 Jan 2021 21:30:26 GMT

If you need to run more than one statement conditionally, use a DO-END:

then do;
  str_2 = substr(str, startpos+7, endpos-(startpos+7));
  str_1 = cats(substr(str_1, 1, startpos), substr(str_1, endpos));
end;
else str_1; /* zhis is not a valid statement */

Re: Error using if then else loop

Reeza — Fri, 22 Jan 2021 21:35:40 GMT

data A;
set B;

length str_2 $1000;
if (startpos = index(str_1, "START") and endpos - index(str_1, "STOP")) then 
     do;
           str_2 = substr(str, startpos+7, endpos-(startpos+7));
           str_1 = cats(substr(str_1, 1, startpos), substr(str_1, endpos));
     end; 
else str_2 = str_1;

run;

IF/THEN versus IF/THEN/DO, if there are multiple statements after the IF statement it requires a DO/END block as well.
The ELSE condition is incorrect. Should that be assigned to a variable ? Not sure what the else should do so just made a guess.
There's a missing semicolon on the LENGTH statement.

FYI - formatting the code makes it easier to see these issues. Highlight the code and press CTRL+I in EG or click the format code button in SAS Studio to format your code before posting.

@SAS_New_User1 wrote:

I am running the below query and I keep getting the error

data A;

set B;

length str_2 $1000

if

(

startpos = index(str_1, "START")

and

endpos - index(str_1, "STOP")

)

then

str_2 = substr(str, startpos+7, endpos-(startpos+7));

str_1 = cats(substr(str_1, 1, startpos), substr(str_1, endpos));

else str_1;

run;

I am getting the below error:

Error: No matching ID-THEN clause

Error: Statement is not valid or it is not used out of proper order.

What am I doing wrong?

Re: Error using if then else loop

SAS_New_User1 — Fri, 22 Jan 2021 21:36:11 GMT

I am trying to use IF then loop and see if I am able to find START and STOP, if not then I want to keep the data as is, I.e. the str_1 should not change in that case.

Currently if the string either does not find START or STOP it replaces the str_1(original data) with additional data from the string.

So I am trying to say that if the START and STOP exists in the query do the conditions else keep the data the same

Re: Error using if then else loop

SAS_New_User1 — Fri, 22 Jan 2021 21:46:58 GMT

Hi Reeza,

I do not want STR_1 to change. Currently because of the cats function in the do loop if it doesn't find either START or strop. It will concatenate extra string at at the back of STR_1.

So I want to tell the code if A exists then do B, else keep A the same;

The above code is changing Str_1 if either of the START or STOP are missing

Re: Error using if then else loop

Reeza — Fri, 22 Jan 2021 21:54:01 GMT

I can only comment on the syntax issues. If the code has logical issues, you need to provide data, explain what logic you're trying to implement and then we can help you out from there.

Note that A is a data set, so you're checking if your data set exists within a data set? A very clear, detailed example will help you get an answer quickly.

Re: Error using if then else loop

Kurt_Bremser — Fri, 22 Jan 2021 22:05:41 GMT

@SAS_New_User1 wrote:

I am trying to use IF then loop and see if I am able to find START and STOP, if not then I want to keep the data as is, I.e. the str_1 should not change in that case.

Currently if the string either does not find START or STOP it replaces the str_1(original data) with additional data from the string.

So I am trying to say that if the START and STOP exists in the query do the conditions else keep the data the same

Then you do not need the ELSE branch at all.

Re: Error using if then else loop

SAS_New_User1 — Fri, 22 Jan 2021 22:10:58 GMT

In this case it is not updating anything in STR_2 column.