topic Re: correction of macrocode needed in New SAS User

topic Re: correction of macrocode needed in New SAS User https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692518#M24913 <BLOCKQUOTE><HR /><a href="https://communities.sas.com/t5/user/viewprofilepage/user-id/281554">@PierreYvesILY</a> wrote:<BR /> <P>hello Paige,</P> <P> </P> <P>I'm a SAS new user, and I don't know much about macrocode.</P> <P>%superq and %qsysfunc are functions I don't know at all.</P> <P>Finally, what I Need is :</P> <P>1. a macro Monat where the month as a 'number' is saved : for instance: January =1 and December = 12.</P> <P>The &Monat. has to be the month BEFORE the &Auswertungstag.</P> <P>therefore: if &Auswertungstag. = '01JAN2021'D => &Monat. = 12</P> <HR /></BLOCKQUOTE> <P>So, this is not the original problem. It really helps if you state the actual problem in your original message, rather than changing it after we have worked on your problem.</P> <P> </P> <P>Try this:</P> <P> </P> <PRE><CODE class=" language-sas"> %let Auswertungstag = %sysevalf('01JAN2020'd); *Bei Bedarf: Datum vorgeben; %let previous_month = %sysfunc(intnx(month,&Auswertungstag,-1,b)); %let year=%sysfunc(year(&previous_month)); %let month=%sysfunc(month(&previous_month)); %put &=Auswertungstag; %put &=previous_month; %put &=year; %put &=month;</CODE></PRE> <P> An important point here, whenever you deal with calendar dates is to represent the data as a valid SAS date, which means the number of days since January 1, 1960. So, January 1, 2020 is represented as 21915. Then you can find the previous month using the INTNX function, so you don't have to write your own code that knows what month comes before any specified month, SAS has already created a function to do this.</P> Mon, 19 Oct 2020 13:37:18 GMT PaigeMiller 2020-10-19T13:37:18Z correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692489#M24899 <P>Hello,</P><P>my Code:</P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Auswertungstag = '01OCT2020'D; </FONT><FONT face="Courier New" size="3" color="#008000">*Bei Bedarf: Datum vorgeben;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Spanne=9; </FONT><FONT face="Courier New" size="3" color="#008000">*Spanne: Anzahl der Monate des Dashboardszeitraum;</FONT></P><P><FONT face="Courier New" size="3" color="#008000">*Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Monat= </FONT><FONT face="Courier New" size="3" color="#0000ff">%eval</FONT><FONT face="Courier New" size="3">(%month(&Auswertungstag.)); </FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Jahr1= </FONT><FONT face="Courier New" size="3" color="#0000ff">%eval</FONT><FONT face="Courier New" size="3">(%year(&Auswertungstag.)); </FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Jahr2= </FONT><FONT face="Courier New" size="3" color="#0000ff">%eval</FONT><FONT face="Courier New" size="3">(&Jahr1.-1);</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &Auswertungstag.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &Spanne.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &Monat.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &Jahr1.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &Jahr2.;</FONT></P><P> </P><P>I get following Errors in the log:</P><P> </P><P>GOPTIONS ACCESSIBLE;</P><P>27 %let Auswertungstag = '01OCT2020'D;</P><P>28 %let Spanne=9;</P><P>29</P><P>30 %let Monat= %eval(%month(&Auswertungstag.));</P><P>31 %let Jahr1= %eval(%year(&Auswertungstag.));</P><P>NOTE: The quoted string currently being processed has become more than 262 bytes long. You might have unbalanced quotation marks.</P><P>32 %let Jahr2= %eval(&Jahr1.-1);</P><P>33 %put &Auswertungstag.;</P><P>34 %put &Spanne.;</P><P>35 %put &Monat.;</P><P>36 %put &Jahr1.;</P><P>37 %put &Jahr2.;</P><P> </P><P>Why is there no result in the log after the %put Statement?</P><P>it seems it doesn't calculate anything.</P><P> </P><P>How can I correct this?</P><P> </P><P> </P><P> </P> Mon, 19 Oct 2020 11:50:33 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692489#M24899 PierreYvesILY 2020-10-19T11:50:33Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692490#M24900 <P>I get different errors in the LOG when I run this exact code. </P> <P> </P> <P>There is no such thing as a %MONTH or %YEAR macro function.</P> <P> </P> <P>But this works, keeping in mind <A href="https://communities.sas.com/t5/SAS-Communities-Library/Maxims-of-Maximally-Efficient-SAS-Programmers/ta-p/352068" target="_self">Maxim 28</A> which says you should not format macro variables (so &Auswertungstag is not formatted)</P> <P> </P> <P> </P> <PRE><CODE class=" language-sas">%let Auswertungstag = %sysevalf('01OCT2020'd); *Bei Bedarf: Datum vorgeben; %let Spanne=9; *Spanne: Anzahl der Monate des Dashboardszeitraum; *Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag; %let Monat= %sysfunc(month(&Auswertungstag.)); %let Jahr1= %sysfunc(year(&Auswertungstag.)); %let Jahr2= %eval(&Jahr1.-1); %put &=Auswertungstag.; %put &=Spanne.; %put &=Monat.; %put &=Jahr1.; %put &=Jahr2.;</CODE></PRE> <P> </P> <P> </P> Mon, 19 Oct 2020 11:58:12 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692490#M24900 PaigeMiller 2020-10-19T11:58:12Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692494#M24901 <P>hallo Paige,</P><P> </P><P>I've got the following error messages ; is it possible, that it is due to SAS 9.3?</P><P> </P><P>43 %let Auswertungstag = %sysevalf('01OCT2020'd); *Bei Bedarf: Datum vorgeben;</P><P>ERROR: Open code statement recursion detected.</P><P>44 %let Spanne=9; *Spanne: Anzahl der Monate des Dashboardszeitraum;</P><P>ERROR: Open code statement recursion detected.</P><P>45 *Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag;</P><P>46 %let Monat= %sysfunc(month(&Auswertungstag.));</P><P>ERROR: Open code statement recursion detected.</P><P>47 %let Jahr1= %sysfunc(year(&Auswertungstag.));</P><P>ERROR: Open code statement recursion detected.</P><P>2 The SAS System 13:41 Monday, October 19, 2020</P><P>48 %let Jahr2= %eval(&Jahr1.-1);</P><P>ERROR: Open code statement recursion detected.</P><P>49 %put &=Auswertungstag.;</P><P>ERROR: Open code statement recursion detected.</P><P>50 %put &=Spanne.;</P><P>ERROR: Open code statement recursion detected.</P><P>51 %put &=Monat.;</P><P>ERROR: Open code statement recursion detected.</P><P>52 %put &=Jahr1.;</P><P>ERROR: Open code statement recursion detected.</P><P>53 %put &=Jahr2.;</P><P>ERROR: Open code statement recursion detected.</P><P>54</P><P>55 GOPTIONS NOACCESSIBLE;</P><P>56 %LET _CLIENTTASKLABEL=;</P><P>ERROR: Open code statement recursion detected.</P><P>57 %LET _CLIENTPROCESSFLOWNAME=;</P><P>ERROR: Open code statement recursion detected.</P><P>58 %LET _CLIENTPROJECTPATH=;</P><P>ERROR: Open code statement recursion detected.</P><P>59 %LET _CLIENTPROJECTPATHHOST=;</P><P>ERROR: Open code statement recursion detected.</P><P>60 %LET _CLIENTPROJECTNAME=;</P><P>ERROR: Open code statement recursion detected.</P><P>61 %LET _SASPROGRAMFILE=;</P><P>ERROR: Open code statement recursion detected.</P><P>62 %LET _SASPROGRAMFILEHOST=;</P><P>ERROR: Open code statement recursion detected.</P><P>63</P> Mon, 19 Oct 2020 12:10:56 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692494#M24901 PierreYvesILY 2020-10-19T12:10:56Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692497#M24902 <P>What happens if you close SAS, and then re-start it and run the code I showed?</P> Mon, 19 Oct 2020 13:10:09 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692497#M24902 PaigeMiller 2020-10-19T13:10:09Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692501#M24903 <P>From the last SAS log you sent I can see you're using Enterprise Guide to write your SAS code. The "open code recursion" error most frequently occurs when a macro statement has previously been submitted without a semicolon. Try resetting your SAS session an submitting this code from a fresh SAS session:</P> <PRE><CODE class=" language-sas">%macro month(sasdate); %qsysfunc(month(%superq(sasdate))) %mend; %macro year(sasdate); %qsysfunc(year(%superq(sasdate))) %mend; %let Auswertungstag = '01OCT2020'D; *Bei Bedarf: Datum vorgeben; %let Spanne=9; *Spanne: Anzahl der Monate des Dashboardszeitraum; *Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag; %let Monat= %eval(%month(&Auswertungstag.)); %let Jahr1= %eval(%year(&Auswertungstag.)); %let Jahr2= %eval(&Jahr1.-1); %put NOTE: &=Auswertungstag.; %put NOTE: &=Spanne. &=Monat. &=Jahr1. &=Jahr2.; %put NOTE: Subnmitted from &_CLIENTAPP version &_CLIENTVERSION; %put NOTE- Running on SAS version &sysvlong;</CODE></PRE> <P>This code runs without error or warnings for me from Enterprise Guide 8.2 running SAS 9.4M7. </P> <P> </P> <P>The last two lines should provide <EM>your</EM> Enterprise Guide and SAS version information, which might be helpful if further troubleshooting is necessary. </P> <P> </P> <P> </P> Mon, 19 Oct 2020 12:47:27 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692501#M24903 SASJedi 2020-10-19T12:47:27Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692505#M24905 <UL> <LI>Why do you need %superq here?</LI> <LI>Why do you need %qsysfunc instead of %sysfunc? (Month and year values should not require any macro quoting)</LI> <LI>Why do you need %eval(%month(&Auswertungstag.)) instead of %month(&Auswertungstag.)?</LI> </UL> <P>The code work properly without %superq and without %eval and with %sysfunc instead of %qsysfunc</P> Mon, 19 Oct 2020 13:03:26 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692505#M24905 PaigeMiller 2020-10-19T13:03:26Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692512#M24909 <P>hello Paige,</P><P> </P><P>I'm a SAS new user, and I don't know much about macrocode.</P><P>%superq and %qsysfunc are functions I don't know at all.</P><P>Finally, what I Need is :</P><P>1. a macro Monat where the month as a 'number' is saved : for instance: January =1 and December = 12.</P><P>The &Monat. has to be the month BEFORE the &Auswertungstag.</P><P>therefore: if &Auswertungstag. = '01JAN2021'D => &Monat. = 12</P><P>2. a macro Jahr1 where the year of that given monat is stored.</P><P>&Auswertungstag. = '01JAN2021'D => &Monat. = 12 and &Jahr1.=2020</P><P>&Auswertungstag. = '01DEC2020'D => &Monat. = 11 and &Jahr1.=2020</P><P>&Auswertungstag. = '01FEB2021'D => &Monat. = 1 and &Jahr1.=2021</P><P>I tried:</P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Auswertungstag = </FONT><FONT face="Courier New" size="3" color="#0000ff">%sysevalf</FONT><FONT face="Courier New" size="3">('01OCT2020'd); </FONT><FONT face="Courier New" size="3" color="#008000">*Bei Bedarf: Datum vorgeben;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Spanne=9; </FONT><FONT face="Courier New" size="3" color="#008000">*Spanne: Anzahl der Monate des Dashboardszeitraum;</FONT></P><P> </P><P>*Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag;</P><P><FONT face="Courier New" size="3" color="#0000ff">%if</FONT> <FONT face="Courier New" size="3" color="#0000ff">%sysfunc</FONT><FONT face="Courier New" size="3">(month(&</FONT><FONT face="Courier New" size="3" color="#008080">Auswertungstag.</FONT><FONT face="Courier New" size="3">)) ne </FONT><STRONG><FONT face="Courier New" size="3" color="#008080">0</FONT></STRONG> <FONT face="Courier New" size="3" color="#0000ff">%then</FONT> <FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Monat=</FONT><FONT face="Courier New" size="3" color="#0000ff">%sysfunc</FONT><FONT face="Courier New" size="3">(month(&Auswertungstag.));</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%else</FONT> <FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Monat=12;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%if</FONT><FONT face="Courier New" size="3"> &Monat ne </FONT><STRONG><FONT face="Courier New" size="3" color="#008080">12</FONT></STRONG> <FONT face="Courier New" size="3" color="#0000ff">%then</FONT> <FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Jahr1= </FONT><FONT face="Courier New" size="3" color="#0000ff">%sysfunc</FONT><FONT face="Courier New" size="3">(year(&Auswertungstag.)); </FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%else</FONT> <FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Jahr1= </FONT><FONT face="Courier New" size="3" color="#0000ff">%sysfunc</FONT><FONT face="Courier New" size="3">(year(&Auswertungstag.)-1);</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%let</FONT><FONT face="Courier New" size="3"> Jahr2= </FONT><FONT face="Courier New" size="3" color="#0000ff">%eval</FONT><FONT face="Courier New" size="3">(&Jahr1.-1);</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &=Auswertungstag.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &=Spanne.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &=Monat.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &=Jahr1.;</FONT></P><P><FONT face="Courier New" size="3" color="#0000ff">%put</FONT><FONT face="Courier New" size="3"> &=Jahr2.;</FONT></P><P> </P><P><FONT face="Courier New" size="3">and I got the Errors:</FONT></P><P>ERROR: The %IF statement is not valid in open code.</P><P>ERROR: The %ELSE statement is not valid in open code.</P><P> </P><P>Could you help to correct this?</P><P> </P><P>Thanks for your help</P><P> </P><P> </P> Mon, 19 Oct 2020 13:19:08 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692512#M24909 PierreYvesILY 2020-10-19T13:19:08Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692515#M24911 <P>hello,</P><P> </P><P>thank you for your help.</P><P> </P><P>the results of the Code:</P><P>930 %let Auswertungstag = '01OCT2020'D; *Bei Bedarf: Datum vorgeben;</P><P>931 %let Spanne=9; *Spanne: Anzahl der Monate des Dashboardszeitraum;</P><P>932 *Der Monatszeitraum fängt an, mit dem Vormonat von dem Auswertungstag;</P><P>933 %let Monat= %eval(%month(&Auswertungstag.));</P><P>934 %let Jahr1= %eval(%year(&Auswertungstag.));</P><P>935 %let Jahr2= %eval(&Jahr1.-1);</P><P>936 %put NOTE: &=Auswertungstag.;</P><P>NOTE: AUSWERTUNGSTAG='01OCT2020'D</P><P>937 %put NOTE: &=Spanne. &=Monat. &=Jahr1. &=Jahr2.;</P><P>10 The SAS System 14:47 Monday, October 19, 2020</P><P>NOTE: SPANNE=9 MONAT=10 JAHR1=2020 JAHR2=2019</P><P>938 %put NOTE: Subnmitted from &_CLIENTAPP version &_CLIENTVERSION;</P><P>NOTE: Subnmitted from 'SAS Enterprise Guide' version '7.100.5.6214'</P><P>939 %put NOTE- Running on SAS version &sysvlong;</P><P>Running on SAS version 9.03.01M2P081512</P> Mon, 19 Oct 2020 13:23:46 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692515#M24911 PierreYvesILY 2020-10-19T13:23:46Z Re: correction of macrocode needed https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692518#M24913 <BLOCKQUOTE><HR /><a href="https://communities.sas.com/t5/user/viewprofilepage/user-id/281554">@PierreYvesILY</a> wrote:<BR /> <P>hello Paige,</P> <P> </P> <P>I'm a SAS new user, and I don't know much about macrocode.</P> <P>%superq and %qsysfunc are functions I don't know at all.</P> <P>Finally, what I Need is :</P> <P>1. a macro Monat where the month as a 'number' is saved : for instance: January =1 and December = 12.</P> <P>The &Monat. has to be the month BEFORE the &Auswertungstag.</P> <P>therefore: if &Auswertungstag. = '01JAN2021'D => &Monat. = 12</P> <HR /></BLOCKQUOTE> <P>So, this is not the original problem. It really helps if you state the actual problem in your original message, rather than changing it after we have worked on your problem.</P> <P> </P> <P>Try this:</P> <P> </P> <PRE><CODE class=" language-sas"> %let Auswertungstag = %sysevalf('01JAN2020'd); *Bei Bedarf: Datum vorgeben; %let previous_month = %sysfunc(intnx(month,&Auswertungstag,-1,b)); %let year=%sysfunc(year(&previous_month)); %let month=%sysfunc(month(&previous_month)); %put &=Auswertungstag; %put &=previous_month; %put &=year; %put &=month;</CODE></PRE> <P> An important point here, whenever you deal with calendar dates is to represent the data as a valid SAS date, which means the number of days since January 1, 1960. So, January 1, 2020 is represented as 21915. Then you can find the previous month using the INTNX function, so you don't have to write your own code that knows what month comes before any specified month, SAS has already created a function to do this.</P> Mon, 19 Oct 2020 13:37:18 GMT https://communities.sas.com/t5/New-SAS-User/correction-of-macrocode-needed/m-p/692518#M24913 PaigeMiller 2020-10-19T13:37:18Z