topic Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro in New SAS User

Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 16:05:02 GMT

So I am running into some issues here:

Following is the macro I am running to estimate the rate per 1000. The PROC GENMOD is running without any issue, however, in the second part where I am trying to access the same variable and perform some arithmetic operation, it is throwing the following error:

" Statement is not valid or it is used out of proper order"

Wondering it has to do with accessing the macro variable and corresponding numeric value from the dataset internally. But not quite getting the coding right. Any feedback or suggestion is appreciated!

Thanks!

%macro rate1(dat,vars);
%do i = 1 %to %sysfunc(countw(&vars.));
	%put %scan(&vars., &i.);
	%LET newv=%scan(&vars., &i.);

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;
	model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
	estimate 'Mean' intercept 1;
	title " cases for in &newv";
	run;



	proc print data=new_Results;
	id n %scan(&vars., &i.);
	inputval=INPUT(SYMGET(%scan(&vars., &i.));
	IR=inputval/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, inputval*2)/(n*2);
	UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	title "rate per 1K  another way";
	run;

%END;

%mend rate1;


%run_pr(x_trans,c_tot);

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

tomrvincent — Fri, 16 Aug 2019 16:31:49 GMT

You might want to show us the code for the run_pr macro.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 16:38:32 GMT

872  data x_trans;
873   infile cards;
874   input n c_tot c_etopfa c_sb c_lb;
875   ln=log(n);
876   dummy=1;
877   datalines;

NOTE: The data set WORK.X_TRANS has 1 observations and 7 variables.
NOTE: DATA statement used (Total process time):
      real time           0.01 seconds
      cpu time            0.00 seconds


879  ;
880  run;

881  %macro rate1(dat,vars);
882  %do i = 1 %to %sysfunc(countw(&vars.));
883      %put %scan(&vars., &i.);
884      %LET newv=%scan(&vars., &i.);
885
886      data new_Results;
887      set &dat.;
888      proc genmod data=&dat.;
889      model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
890      estimate 'Mean' intercept 1;
891      title " cases for in &newv";
892      run;
893
894
895
896      proc print data=new_Results;
897      id n %scan(&vars., &i.);
898      inputval=INPUT(SYMGET(%scan(&vars., &i.));
899      IR=inputval/n;
900      IR_1K=IR*1000;
901      LC=quantile('chisq',0.025, inputval*2)/(n*2);
902      UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
903      res_l=LC*1000;
904      res_u=UC*1000;
905      title "rate per 1K  another way";
906      run;
907
908  %END;
909
910  %mend rate1;

911  %run_pr(x_trans,c_tot);
c_tot

NOTE: There were 1 observations read from the data set WORK.X_TRANS.
NOTE: The data set WORK.NEW_RESULTS has 1 observations and 7 variables.
NOTE: DATA statement used (Total process time):
      real time           0.01 seconds
      cpu time            0.00 seconds


NOTE: Writing HTML Body file: sashtml4.htm


NOTE: Fitting saturated model. Scale will not be estimated.
NOTE: Algorithm converged.
NOTE: The scale parameter was held fixed.
NOTE: PROCEDURE GENMOD used (Total process time):
      real time           0.84 seconds
      cpu time            0.26 seconds


ERROR: A character operand was found in the %EVAL function or %IF condition where a numeric
       operand is required. The condition was: NUVAR
ERROR: The macro RUN_PR will stop executing.

This is the code I am getting

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Tom — Fri, 16 Aug 2019 16:44:55 GMT

Looks like the macro run_pr has a bug.

Do you have the source code that macro?

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 16:54:35 GMT

This is the code I wrote.

%macro rate1(dat,vars);
%do i = 1 %to %sysfunc(countw(&vars.));
	%put %scan(&vars., &i.);
	%LET newv=%scan(&vars., &i.);

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;
	model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
	estimate 'Mean' intercept 1;
	title " cases for in &newv";
	run;



	proc print data=new_Results;
	id n %scan(&vars., &i.);
	inputval=INPUT(SYMGET(%scan(&vars., &i.));
	IR=inputval/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, inputval*2)/(n*2);
	UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	title "rate per 1K  another way";
	run;

%END;

%mend rate1;


%run_pr(x_trans,c_tot);

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

ballardw — Fri, 16 Aug 2019 17:12:48 GMT

Unless proc print has changed a lot since version 9.4M4 none of the highlighted code is valid in Proc Print:

proc print data=new_Results;
897      id n %scan(&vars., &i.);
898      inputval=INPUT(SYMGET(%scan(&vars., &i.));
899      IR=inputval/n;
900      IR_1K=IR*1000;
901      LC=quantile('chisq',0.025, inputval*2)/(n*2);
902      UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
903      res_l=LC*1000;
904      res_u=UC*1000;
905      title "rate per 1K  another way";
906      run;

Print does just that, Prints. It can do some column sums but those other calculations are right out.

Also the INPUT function would require a format and I strongly suspect you do not actually have the macro variable you would be attempting to reference with that SYMGET call.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Tom — Fri, 16 Aug 2019 17:15:13 GMT

Why did you send the code for the macro RATE1 when you are not calling that macro?

You are calling the macro RUN_PR.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Reeza — Fri, 16 Aug 2019 17:18:00 GMT

@sigma_exp wrote:

This is the code I wrote.

%macro rate1(dat,vars);
%do i = 1 %to %sysfunc(countw(&vars.));
	%put %scan(&vars., &i.);
	%LET newv=%scan(&vars., &i.);

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;
	model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
	estimate 'Mean' intercept 1;
	title " cases for in &newv";
	run;



	proc print data=new_Results;
	id n %scan(&vars., &i.);
	inputval=INPUT(SYMGET(%scan(&vars., &i.));
	IR=inputval/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, inputval*2)/(n*2);
	UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	title "rate per 1K  another way";
	run;

%END;

%mend rate1;


%run_pr(x_trans,c_tot);

Why do you create newv macro variable but never use it?

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

tomrvincent — Fri, 16 Aug 2019 17:28:17 GMT

still not seeing the code for run_pr...can't help you without it.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

tomrvincent — Fri, 16 Aug 2019 17:29:17 GMT

that's the code for rate1. We need to see the code for run_pr. Get it?

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Reeza — Fri, 16 Aug 2019 17:32:25 GMT

NOTE: The data set WORK.NEW_RESULTS has 1 observations and 7 variables.

If your subset has 1 observation then you cannot run a regression. Something is wrong with your input data.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 17:37:24 GMT

My mistake: please see the code below:



%macro rate1(dat,vars);
%do i = 1 %to %sysfunc(countw(&vars.));
	%put %scan(&vars., &i.);
	%LET newv=%scan(&vars., &i.);

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;
	model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
	estimate 'Mean' intercept 1;
	title " cases for in &newv";
	run;



	proc print data=new_Results;
	id n %scan(&vars., &i.);
	inputval=INPUT(SYMGET(%scan(&vars., &i.));
	IR=inputval/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, inputval*2)/(n*2);
	UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	title "rate per 1K  another way";
	run;

%END;

%mend rate1;


%rate1(x_trans,c_tot);

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 17:39:16 GMT

As a count data, I have the parameter estimates and without running the MACRO, in a DATA with PROC GENMOD, it is running without giving any error.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 17:42:06 GMT

When I run as a DATA step without using macro, it gives out the specific estimates. For example, instead of using "inputval", if I directly use the "c_tot") with the data=new_Results, it has those estimates. I wonder how can I access the value of "c_tot" by referencing it as a macro variable and perform the arithmetic operations? I guess this is a better way to rephrase my original question.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Reeza — Fri, 16 Aug 2019 18:00:47 GMT

You're right, technically no errors.

NOTE: Fitting saturated model. Scale will not be estimated.
NOTE: Algorithm converged.
NOTE: The scale parameter was held fixed.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Tom — Fri, 16 Aug 2019 18:02:26 GMT

So now run the updated program. Add the line:

options mprint;

Before the macro call. The MPRINT lines in the LOG will show you what code your macro generates. Try to figure out how to have it generate the code you actually want.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

ballardw — Fri, 16 Aug 2019 18:05:26 GMT

Let's try this one more time:
Proc print will not let you do calculations in the code. Example:

534  proc print data=sashelp.class;
535
536  heightweight = height/weight;
     ------------
     180
ERROR 180-322: Statement is not valid or it is used out of proper order.
537  run;

So this proc print step is going to Fail:

	proc print data=new_Results;
	id n %scan(&vars., &i.);
	inputval=INPUT(SYMGET(%scan(&vars., &i.));
	IR=inputval/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, inputval*2)/(n*2);
	UC=quantile('chisq',0.975, (inputval+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	title "rate per 1K  another way";
	run;

Fail. Period. End of story. Doesn't matter what data set is used, what erroneous macro variables may be involved, every statement with an = shown is an error.

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 18:15:35 GMT

thank you for clarifying --you are absolutely right. In fact, it is because you pointed it out, I was able to find the bug. I am posting the updated code below. It fixes the problem. Thanks again!

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

sigma_exp — Fri, 16 Aug 2019 18:17:36 GMT

So here is the updated macro I wrote. It fixes the problem and generates the output I was looking for. Thank you all for providing valuable feedback and input to get me to write this one.

%macro rate1(dat,vars);
%do i = 1 %to %sysfunc(countw(&vars.));
	%put %scan(&vars., &i.);
	*%LET newv=%scan(&vars., &i.);

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;
	model  %scan(&vars., &i.) = / offset=ln dist=poisson lrci;
	estimate 'Mean' intercept 1;
	title " cases for in &newv";
	run;



	data new_Results2;
	set &dat.;
	IR=%scan(&vars., &i.)/n;
	IR_1K=IR*1000;
	LC=quantile('chisq',0.025, %scan(&vars., &i.)*2)/(n*2);
	UC=quantile('chisq',0.975, (%scan(&vars., &i.)+1)*2)/(n*2);
	res_l=LC*1000;
	res_u=UC*1000;
	run;
	
	
	proc print data=new_Results2;
	id n %scan(&vars., &i.);
	title "rate per 1K  another way";
	run;

%END;

%mend rate1;

Re: Accessing corresponding numeric value from a dataset using macro variable inside a macro

Tom — Fri, 16 Aug 2019 18:36:37 GMT

Why do you have the first two of these three lines?

	data new_Results; 
	set &dat.;
	proc genmod data=&dat.;

What do you think the first two lines are doing?