topic Re: Macro not running at all, no errors. in New SAS User

Macro not running at all, no errors.

accintron — Wed, 14 Aug 2019 14:36:05 GMT

I've tried restarting my SAS program and computer and this macro is just not running, no errors, nothing - just the code is in the log... I'm probably missing the simplest thing... am I calling in the macro variables correctly? I know sometimes you utilize a period so I thought that would be appropriate for the second macro variable.... Thanks for your help in advance!

%macro DX(no=, var=);

proc sql;
create table dx_&no as
select a.admission_id, b.DIAG_DESC
from adms_5 a left join table.DIAGNOSIS b on a.&var.=b.DIAG_CD;
quit;

%DX(no=1, var=DIAG_CD_1);
%DX(no=2, var=DIAG_CD_2_1);
%DX(no=3, var=DIAG_CD_2_4);

%mend DX;

Re: Macro not running at all, no errors.

PaigeMiller — Wed, 14 Aug 2019 14:38:17 GMT

You defined the macro, you never told SAS to execute the macro after it has been defined.

These go after %MEND;

%DX(no=1, var=DIAG_CD_1)
%DX(no=2, var=DIAG_CD_2_1)
%DX(no=3, var=DIAG_CD_2_4)

Re: Macro not running at all, no errors.

ballardw — Wed, 14 Aug 2019 14:39:23 GMT

@accintron wrote:

I've tried restarting my SAS program and computer and this macro is just not running, no errors, nothing - just the code is in the log... I'm probably missing the simplest thing... am I calling in the macro variables correctly? I know sometimes you utilize a period so I thought that would be appropriate for the second macro variable.... Thanks for your help in advance!

%macro DX(no=, var=);

proc sql;
create table dx_&no as
select a.admission_id, b.DIAG_DESC
from adms_5 a left join table.DIAGNOSIS b on a.&var.=b.DIAG_CD;
quit;

%DX(no=1, var=DIAG_CD_1);
%DX(no=2, var=DIAG_CD_2_1);
%DX(no=3, var=DIAG_CD_2_4);

%mend DX;

Try:

%macro DX(no=, var=);

proc sql;
create table dx_&no as
select a.admission_id, b.DIAG_DESC
from adms_5 a left join table.DIAGNOSIS b on a.&var.=b.DIAG_CD;
quit;

%mend DX; 

%DX(no=1, var=DIAG_CD_1);
%DX(no=2, var=DIAG_CD_2_1);
%DX(no=3, var=DIAG_CD_2_4);

Attempting to use the macro in the defining code is a path to madness and unexpected results.

I would also suggest shutting down SAS and restarting as you may have created an very unstable situation.

Re: Macro not running at all, no errors.

accintron — Wed, 14 Aug 2019 14:41:46 GMT

Woops! Thanks!! Yes, that worked and I had to use . after my &no macro variable.

Re: Macro not running at all, no errors.

accintron — Wed, 14 Aug 2019 14:42:49 GMT

Thank you! Yes, definitely will restart SAS fresh now that the code is working appropriately!