topic How to write a code in this situation. in New SAS User

How to write a code in this situation.

ramtejdasari — Wed, 15 May 2019 20:57:09 GMT

I am working on multiple clinical trials and I am using single program for all these individual trial. I came across with the situation where I need to derive 10 variables using X dataset for all the 3 trials. but unfortunately for one trial I need to derive all these 10 variables using Y dataset. The variables I need to use to derive all these 10 new variables in the dataset X & Y are same but only difference is the dataset names X & Y. How can I write this in a single piece of code to select Y dataset for one trial else select X dataset for other two trials.

I am using the below code but it is giving me the observations from the second dataset only.

%macro fa;

%if &study = %str(Trial c) %then %do;

data fmh;

set &srcdata..fa;

run;

%end;

%else %do;

data fmh;

set &srcdata..famh;

run;

%end;

%mend;

%fa

Thanks for all your time.

Re: How to write a code in this situation.

ballardw — Wed, 15 May 2019 21:17:08 GMT

Where do you set the value for &study? Your comparison is case sensitive so if you set &study with something like : %let study=Trial C;

it would not match the value Trial c

Source and value for &srcdata?

If &srcdata is not a library then your data reference is incorrect. If it already contains a library.dataset then you do not want the second .

%let srcdata=work.data;
%let setname = &srcdata..famh;
/*invalid data set name*/
%put setname is &setname.;

%let srcdata=dataset;
%let setname = &srcdata..famh;
/*treats what might be data set name as library*/
%put setname is &setname.;

In general it is not best practice to use values in macro code not explicitly passed as parameters. Your code call does not document the expected values sent to the macro with something like %fa

You would be better off using %macro fa (study= , srcdata= ); in the definition and then call as

%fa(study=x, srcdata=lib); or what ever values are being used.

Re: How to write a code in this situation.

ramtejdasari — Wed, 15 May 2019 21:42:47 GMT

Hi Ballardw

we have a separate program like studyauto , where we created macro variables for study and srcdata.

I just tried the code by removing %str in the code and it works now.it is related to the &study variable in the studyauto program where we created this.

Again thank you so much for your valuable input. It resolved now.